From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joelaf@google.com>
Cc: linux-kernel@vger.kernel.org, Jessica Yu <jeyu@kernel.org>
Subject: Re: [PATCH RFC] ftrace: Clear hashes of saved init functions
Date: Mon, 9 Oct 2017 11:09:42 -0400 [thread overview]
Message-ID: <20171009110942.731832f4@gandalf.local.home> (raw)
In-Reply-To: <20171008213304.155783-1-joelaf@google.com>
On Sun, 8 Oct 2017 14:33:04 -0700
Joel Fernandes <joelaf@google.com> wrote:
>
> static void
> clear_mod_from_hash(struct ftrace_page *pg, struct ftrace_hash *hash)
> {
> @@ -5771,12 +5807,24 @@ void ftrace_release_mod(struct module *mod)
This is too late. This should be done by ftrace_free_mem().
-- Steve
> {
> struct ftrace_mod_map *mod_map;
> struct ftrace_mod_map *n;
> + struct ftrace_mod_func *mod_func;
> struct dyn_ftrace *rec;
> struct ftrace_page **last_pg;
> struct ftrace_page *tmp_page = NULL;
> struct ftrace_page *pg;
> int order;
>
> + /* mod_map is freed via call_rcu_sched() */
> + preempt_disable();
> + list_for_each_entry_rcu(mod_map, &ftrace_mod_maps, list) {
> + if (mod_map->mod != mod)
> + continue;
> + list_for_each_entry_rcu(mod_func, &mod_map->funcs, list) {
> + clear_mod_func_from_hashes(mod_func);
> + }
> + }
> + preempt_enable();
> +
> mutex_lock(&ftrace_lock);
>
> if (ftrace_disabled)
next prev parent reply other threads:[~2017-10-09 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 21:33 Joel Fernandes
2017-10-09 15:09 ` Steven Rostedt [this message]
2017-10-09 15:33 ` Joel Fernandes
2017-10-09 16:21 ` Steven Rostedt
2017-10-09 16:31 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009110942.731832f4@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jeyu@kernel.org \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®