From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754687AbdJIQV6 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 9 Oct 2017 12:21:58 -0400
Received: from mail.kernel.org ([198.145.29.99]:45370 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752206AbdJIQV5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 9 Oct 2017 12:21:57 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20A512187F
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Mon, 9 Oct 2017 12:21:55 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joelaf@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Jessica Yu <jeyu@kernel.org>
Subject: Re: [PATCH RFC] ftrace: Clear hashes of saved init functions
Message-ID: <20171009122155.44616f36@gandalf.local.home>
In-Reply-To: <CAJWu+orbq4R4aKHS_NJW7kqKZN4+yHJoceLxxaO91zV5LQpX4A@mail.gmail.com>
References: <20171008213304.155783-1-joelaf@google.com>
        <20171009110942.731832f4@gandalf.local.home>
        <CAJWu+orbq4R4aKHS_NJW7kqKZN4+yHJoceLxxaO91zV5LQpX4A@mail.gmail.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 9 Oct 2017 08:33:51 -0700
Joel Fernandes <joelaf@google.com> wrote:

> Hi Steve,
> 
> On Mon, Oct 9, 2017 at 8:09 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Sun,  8 Oct 2017 14:33:04 -0700
> > Joel Fernandes <joelaf@google.com> wrote:
> >  
> >>
> >>  static void
> >>  clear_mod_from_hash(struct ftrace_page *pg, struct ftrace_hash *hash)
> >>  {
> >> @@ -5771,12 +5807,24 @@ void ftrace_release_mod(struct module *mod)  
> >
> > This is too late. This should be done by ftrace_free_mem().
> >  
> 
> Ok, I agree with you. Initially I started to do it this way but the
> locking made it more complicated. I'll work on a patch that does it at
> free_mem time and send it out today.
> 

Yeah, I noticed that too. You may have to allocate pages to store what
is getting cleared. Of course that then begs the question, what do we
do when we fail to allocate? Perhaps just WARN_ONCE() and then let them
leak?

-- Steve