From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754754AbdJIO1i (ORCPT ); Mon, 9 Oct 2017 10:27:38 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:50116 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754204AbdJIO1Z (ORCPT ); Mon, 9 Oct 2017 10:27:25 -0400 X-Google-Smtp-Source: AOwi7QC/8kmCm6fv8J1YpGjkT6H5N5FaaWA97/6liF8iUsWaSRwwyAiON/d9msbNOLlKJSsU5rayeA== From: Luca Miccio To: axboe@kernel.dk Cc: paolo.valente@linaro.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 1/1] block,bfq: Disable writeback throttling Date: Mon, 9 Oct 2017 16:27:21 +0200 Message-Id: <20171009142721.4262-2-lucmiccio@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171009142721.4262-1-lucmiccio@gmail.com> References: <20171009142721.4262-1-lucmiccio@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Similarly to CFQ, BFQ has its write-throttling heuristics, and it is better not to combine them with further write-throttling heuristics of a different nature. So this commit disables write-back throttling for a device if BFQ is used as I/O scheduler for that device. Signed-off-by: Luca Miccio Signed-off-by: Paolo Valente Tested-by: Oleksandr Natalenko Tested-by: Lee Tibbert --- block/bfq-iosched.c | 3 ++- block/blk-wbt.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index a4783da90ba8..0f860cf0d56d 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -108,6 +108,7 @@ #include "blk-mq-tag.h" #include "blk-mq-sched.h" #include "bfq-iosched.h" +#include "blk-wbt.h" #define BFQ_BFQQ_FNS(name) \ void bfq_mark_bfqq_##name(struct bfq_queue *bfqq) \ @@ -4775,7 +4776,7 @@ static int bfq_init_queue(struct request_queue *q, struct elevator_type *e) bfq_init_root_group(bfqd->root_group, bfqd); bfq_init_entity(&bfqd->oom_bfqq.entity, bfqd->root_group); - + wbt_disable_default(q); return 0; out_free: diff --git a/block/blk-wbt.c b/block/blk-wbt.c index 6a9a0f03a67b..e59d59c11ebb 100644 --- a/block/blk-wbt.c +++ b/block/blk-wbt.c @@ -654,7 +654,7 @@ void wbt_set_write_cache(struct rq_wb *rwb, bool write_cache_on) } /* - * Disable wbt, if enabled by default. Only called from CFQ. + * Disable wbt, if enabled by default. */ void wbt_disable_default(struct request_queue *q) { -- 2.11.0