From: Johannes Thumshirn <jthumshirn@suse.de>
To: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Lee Duncan <lduncan@suse.com>, Hannes Reinecke <hare@suse.de>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
Chris Leech <cleech@redhat.com>
Subject: Re: [PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte
Date: Mon, 9 Oct 2017 16:33:35 +0200 [thread overview]
Message-ID: <20171009143335.l7ilixy46op5ipbx@linux-x5ow.site> (raw)
In-Reply-To: <9105c7ef-0255-520c-3c90-e52a16fa5509@linux.vnet.ibm.com>
On Mon, Oct 09, 2017 at 02:35:06PM +0200, Steffen Maier wrote:
> Use wrapper functions to advertize their use in an attempt to avoid wrong
> shifting in the future?
After a second thought and a bit of coccinelle magic I converted all drivers
under drivers/scsi to use set_host_byte(), msg and driver byte will follow as
well.
But all this is on top of this patch, which IMHO is stable material (we had an
actual customer bug with this).
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-10-09 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 11:33 Johannes Thumshirn
2017-10-09 12:35 ` Steffen Maier
2017-10-09 12:46 ` Johannes Thumshirn
2017-10-09 14:33 ` Johannes Thumshirn [this message]
2017-10-09 21:26 ` Lee Duncan
2017-10-10 15:20 ` Hannes Reinecke
2017-10-11 17:34 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009143335.l7ilixy46op5ipbx@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=Bart.VanAssche@sandisk.com \
--cc=cleech@redhat.com \
--cc=hare@suse.de \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.vnet.ibm.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®