From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754745AbdJIPGy (ORCPT ); Mon, 9 Oct 2017 11:06:54 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:58364 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754066AbdJIPGx (ORCPT ); Mon, 9 Oct 2017 11:06:53 -0400 Date: Mon, 9 Oct 2017 16:06:47 +0100 From: Russell King - ARM Linux To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ARM: add KBUILD_ prefix to CFLAGS_MODULE, LDFLAGS_MODULE Message-ID: <20171009150647.GU20805@n2100.armlinux.org.uk> References: <1507559715-30918-1-git-send-email-yamada.masahiro@socionext.com> <1507559715-30918-2-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507559715-30918-2-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 09, 2017 at 11:35:13PM +0900, Masahiro Yamada wrote: > {CFLAGS,LDFLAGS}_MODULE are supposed to be set by users, not by > in-kernel makefiles. > > Documentation/kbuild/makefiles.txt clearly explains the difference: > > KBUILD_CFLAGS_MODULE Options for $(CC) when building modules > > $(KBUILD_CFLAGS_MODULE) is used to add arch-specific options that > are used for $(CC). > From commandline CFLAGS_MODULE shall be used (see kbuild.txt). > > KBUILD_LDFLAGS_MODULE Options for $(LD) when linking modules > > $(KBUILD_LDFLAGS_MODULE) is used to add arch-specific options > used when linking modules. This is often a linker script. > From commandline LDFLAGS_MODULE shall be used (see kbuild.txt). > > Signed-off-by: Masahiro Yamada Acked-by: Russell King -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up