Re: [PATCH] regulator: lp873x: Update the enable mask for LDOs and BUCKs

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

On Mon, Oct 09, 2017 at 06:35:14PM +0300, Tero Kristo wrote:

> The EN signal coming in to the PMIC is actually used to poweroff the system
> completely. There is no other mechanism for doing this in lp873x based
> systems, they removed the bit for controlling dev-power-off from the
> register space. If the EN bit is down for a specific regulator, it won't go
> down when attempting to poweroff the system, otherwise the state of a
> regulator is the result of (EN_PIN | EN_BIT).

This should be clear from the changelog (and probably the code as well).

> I wonder if we should tie this somehow to the system-power-controller
> property though.... If the PMIC is not system-power-controller, we should
> disable the EN_PIN_CTRL from all regulators so that they don't go down if
> the EN_PIN itself is floating for example.

Seems plausible, if someone does decided to use control at runtime the
behaviour can always be changed if the GPIO is present.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]