From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754334AbdJIUNm (ORCPT ); Mon, 9 Oct 2017 16:13:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:37790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752528AbdJIUNk (ORCPT ); Mon, 9 Oct 2017 16:13:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D619218BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 9 Oct 2017 16:13:37 -0400 From: Steven Rostedt To: SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, Ingo Molnar , LKML Subject: Re: [PATCH] kernel/trace: Delete five error messages for a failed memory allocation Message-ID: <20171009161337.7c35911f@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 7 Oct 2017 16:15:14 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 7 Oct 2017 16:10:06 +0200 > > Omit extra messages for a memory allocation failure in these functions. Does memory allocation failures have printk messages? If not, then I think this is removing useful information. -- Steve > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > kernel/trace/trace_kprobe.c | 1 - > kernel/trace/trace_probe.c | 5 ++--- > kernel/trace/trace_selftest.c | 4 +--- > kernel/trace/trace_uprobe.c | 2 -- > 4 files changed, 3 insertions(+), 9 deletions(-) > > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > index 8a907e12b6b9..79a2ee2fc1f4 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -776,7 +776,6 @@ static int create_trace_kprobe(int argc, char **argv) > } > > if (!parg->name) { > - pr_info("Failed to allocate argument[%d] name.\n", i); > ret = -ENOMEM; > goto error; > } > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > index 52478f033f88..cf544d899eaa 100644 > --- a/kernel/trace/trace_probe.c > +++ b/kernel/trace/trace_probe.c > @@ -545,10 +545,9 @@ int traceprobe_parse_probe_arg(char *arg, ssize_t *size, > return -ENOSPC; > } > parg->comm = kstrdup(arg, GFP_KERNEL); > - if (!parg->comm) { > - pr_info("Failed to allocate memory for command '%s'.\n", arg); > + if (!parg->comm) > return -ENOMEM; > - } > + > t = strchr(parg->comm, ':'); > if (t) { > arg[t - parg->comm] = '\0'; > diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c > index cb917cebae29..6a2a57def182 100644 > --- a/kernel/trace/trace_selftest.c > +++ b/kernel/trace/trace_selftest.c > @@ -250,10 +250,8 @@ static int trace_selftest_ops(struct trace_array *tr, int cnt) > > /* Add a dynamic probe */ > dyn_ops = kzalloc(sizeof(*dyn_ops), GFP_KERNEL); > - if (!dyn_ops) { > - printk("MEMORY ERROR "); > + if (!dyn_ops) > goto out; > - } > > dyn_ops->func = trace_selftest_test_dyn_func; > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 4525e0271a53..9131f7372502 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -492,7 +492,6 @@ static int create_trace_uprobe(int argc, char **argv) > tu->filename = kstrdup(filename, GFP_KERNEL); > > if (!tu->filename) { > - pr_info("Failed to allocate filename.\n"); > ret = -ENOMEM; > goto error; > } > @@ -518,7 +517,6 @@ static int create_trace_uprobe(int argc, char **argv) > } > > if (!parg->name) { > - pr_info("Failed to allocate argument[%d] name.\n", i); > ret = -ENOMEM; > goto error; > }