From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755546AbdJIWYg (ORCPT ); Mon, 9 Oct 2017 18:24:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:49916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754172AbdJIWYe (ORCPT ); Mon, 9 Oct 2017 18:24:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3E74218BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 9 Oct 2017 18:24:32 -0400 From: Steven Rostedt To: Michael Sartain Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] trace-cmd: Fix NULL pointer being passed to memcpy Message-ID: <20171009182432.7c2e0d04@gandalf.local.home> In-Reply-To: <20170812173047.840-3-mikesart@fastmail.com> References: <20170812173047.840-1-mikesart@fastmail.com> <20170812173047.840-3-mikesart@fastmail.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Aug 2017 11:30:44 -0600 Michael Sartain wrote: > Signed-off-by: Michael Sartain > --- > trace-output.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/trace-output.c b/trace-output.c > index bfe6331..84b21b0 100644 > --- a/trace-output.c > +++ b/trace-output.c > @@ -929,7 +929,11 @@ tracecmd_add_option(struct tracecmd_output *handle, > free(option); > return NULL; > } > - memcpy(option->data, data, size); > + > + /* Some IDs (like TRACECMD_OPTION_TRACECLOCK) pass NULL data */ > + if (data) > + memcpy(option->data, data, size); Is this a problem, as when this happens, size should be zero. Does it crash with data=NULL and size=0, or have you seen size not be zero? -- Steve > + > list_add_tail(&option->list, &handle->options); > > return option;