From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755494AbdJIW1y (ORCPT ); Mon, 9 Oct 2017 18:27:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:50118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754172AbdJIW1x (ORCPT ); Mon, 9 Oct 2017 18:27:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28AFE218BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 9 Oct 2017 18:27:51 -0400 From: Steven Rostedt To: Michael Sartain Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] trace-cmd: Add ULL suffix to MISSING_EVENTS since ints shouldn't be left shifted by 31 Message-ID: <20171009182751.5e76bd2e@gandalf.local.home> In-Reply-To: <20170812173047.840-4-mikesart@fastmail.com> References: <20170812173047.840-1-mikesart@fastmail.com> <20170812173047.840-4-mikesart@fastmail.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Aug 2017 11:30:45 -0600 Michael Sartain wrote: > Signed-off-by: Michael Sartain > --- > kbuffer-parse.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kbuffer-parse.c b/kbuffer-parse.c > index 4e6e95e..dde642c 100644 > --- a/kbuffer-parse.c > +++ b/kbuffer-parse.c > @@ -24,8 +24,8 @@ > > #include "kbuffer.h" > > -#define MISSING_EVENTS (1 << 31) Actually, why not? This could also be just UL, because it's fine to shift 31, that would give us: 0x80000000 And that bit is all we care for. -- Steve > -#define MISSING_STORED (1 << 30) > +#define MISSING_EVENTS (1ULL << 31) > +#define MISSING_STORED (1ULL << 30) > > #define COMMIT_MASK ((1 << 27) - 1) >