From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755323AbdJIVDy (ORCPT ); Mon, 9 Oct 2017 17:03:54 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:44887 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbdJIVDw (ORCPT ); Mon, 9 Oct 2017 17:03:52 -0400 Date: Mon, 9 Oct 2017 23:03:40 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , Kishon Vijay Abraham I , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Icenowy Zheng Subject: Re: [PATCH 2/6] ARM: sun8i: r40: add USB host port nodes for R40 Message-ID: <20171009210340.ak6wo3vqnwj4gom4@flea.home> References: <20171008042906.46779-1-icenowy@aosc.io> <20171008042906.46779-3-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hdh4muw3sglqehek" Content-Disposition: inline In-Reply-To: <20171008042906.46779-3-icenowy@aosc.io> User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hdh4muw3sglqehek Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 08, 2017 at 04:29:02AM +0000, Icenowy Zheng wrote: > From: Icenowy Zheng >=20 > Allwinner R40 SoC features a USB OTG port and two USB HOST ports. >=20 > Add support for the host ports in the DTSI file. >=20 > The OTG controller still cannot work with existing compatibles, and needs > more investigation. So it's not added yet. >=20 > Signed-off-by: Icenowy Zheng > --- > arch/arm/boot/dts/sun8i-r40.dtsi | 78 ++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 78 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r= 40.dtsi > index d5a6745409ae..f6c917cbbaac 100644 > --- a/arch/arm/boot/dts/sun8i-r40.dtsi > +++ b/arch/arm/boot/dts/sun8i-r40.dtsi > @@ -173,6 +173,84 @@ > #size-cells =3D <0>; > }; > =20 > + usbphy: phy@1c13400 { > + compatible =3D "allwinner,sun8i-r40-usb-phy"; > + reg =3D <0x01c13400 0x14>, > + <0x01c14800 0x4>, > + <0x01c19800 0x4>, > + <0x01c1c800 0x4>; > + reg-names =3D "phy_ctrl", > + "pmu0", > + "pmu1", > + "pmu2"; > + clocks =3D <&ccu CLK_USB_PHY0>, > + <&ccu CLK_USB_PHY1>, > + <&ccu CLK_USB_PHY2>; > + clock-names =3D "usb0_phy", > + "usb1_phy", > + "usb2_phy"; > + resets =3D <&ccu RST_USB_PHY0>, > + <&ccu RST_USB_PHY1>, > + <&ccu RST_USB_PHY2>; > + reset-names =3D "usb0_reset", > + "usb1_reset", > + "usb2_reset"; > + status =3D "disabled"; > + #phy-cells =3D <1>; > + }; > + > + ehci1: usb@1c19000 { > + compatible =3D "allwinner,sun8i-r40-ehci", "generic-ehci"; > + reg =3D <0x01c19000 0x100>; What is the actual size here? > + interrupts =3D ; > + clocks =3D <&ccu CLK_BUS_OHCI1>, > + <&ccu CLK_BUS_EHCI1>, > + <&ccu CLK_USB_OHCI1>; > + resets =3D <&ccu RST_BUS_OHCI1>, > + <&ccu RST_BUS_EHCI1>; Why do you need to take the OHCI resources too? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --hdh4muw3sglqehek Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIbBAEBAgAGBQJZ2+QsAAoJEBx+YmzsjxAgXlUP925KeKHUCyeIa1zq3hdOA+Cn YXoVqSiYbHidpNB9PnlD4UgsaddOTcAT/u3Ugz+Ie3Ise473TaPmdnWXAlxwgeLN wr8vgndSXls/yQG9tveqmxlF+Vaqhw4DsPS+YXu0ugHlir8zGoUYGJhIf5kgFUui xj0LiXsOzunGFh/9sVJmwNTTf32BkpNpeDp2iKUaD192bbv9OG15L6sYI7i57Vtp xrCu2nKc7DgchvmmJ81VuJuZBHI23boTNQK4OALsKC4ghRgzOEsyE6JC8UY6b2QP YU3gdpmKgXYpmheWF5M2yr+fQ24ZEOfJKJAMPLawtRu0VKK6LT/I55Zi2aE9WcCc zy7YGglLEdhzulBL6WmYRzCPOwpbJ4mMDB3nFKxSB4NSF626hoRoNoyhLL0IBP6r SgY0vqfJAOpE9+1PYPIDYvUVPqBhq+rO9nyV9Zulp2Ji6kl+Piu5TynnWEUAAwje I+VHcy4PvDaps9Sw1rCAnlajAWPDMm4HxQvwG0sbaL3ivPJ3JqJwCCpYXa9OpKOB jrdk9cglDrhFKXnsFzSw5LxSKMNsVkIeKWpsg5xZ1yCBTKgozZ57mQgs8l8DCVYm r4zTyXA6PBrO/hsQ8teQGbyW5rfo2wPDhK01yAkPeoRcNr01kt60tCxsPY1zfvSD Qr3yIhCNYmjPjrM1FX0= =oXgh -----END PGP SIGNATURE----- --hdh4muw3sglqehek--