From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755506AbdJJTcz (ORCPT ); Tue, 10 Oct 2017 15:32:55 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52532 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbdJJTcx (ORCPT ); Tue, 10 Oct 2017 15:32:53 -0400 Date: Tue, 10 Oct 2017 12:32:52 -0700 (PDT) Message-Id: <20171010.123252.2026981767835237524.davem@davemloft.net> To: devtimhansen@gmail.com Cc: willemb@google.com, edumazet@google.com, soheil@google.com, pabeni@redhat.com, elena.reshetova@intel.com, tom@quantonium.net, Jason@zx2c4.com, fw@strlen.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.levin@one.verizon.com Subject: Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals. From: David Miller In-Reply-To: <20171009153759.km3lqss7hb72wrze@debian> References: <20171009153759.km3lqss7hb72wrze@debian> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 10 Oct 2017 12:32:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tim Hansen Date: Mon, 9 Oct 2017 11:37:59 -0400 > Fix BUG() calls to use BUG_ON(conditional) macros. > > This was found using make coccicheck M=net/core on linux next > tag next-2017092 > > Signed-off-by: Tim Hansen Althrough there were objections raised, none of them technically stand up, and this does improve code generation for some architectures, so I have applied this. Thanks!