From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755851AbdJJB0N (ORCPT ); Mon, 9 Oct 2017 21:26:13 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48880 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754707AbdJJB0L (ORCPT ); Mon, 9 Oct 2017 21:26:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5352B60392 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=rkuo@codeaurora.org Date: Mon, 9 Oct 2017 20:26:08 -0500 From: Richard Kuo To: Cao jin Cc: linux-kernel@vger.kernel.org, linux-hexagon@vger.kernel.org Subject: Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE Message-ID: <20171010012608.GA23555@codeaurora.org> References: <1507533107-2069-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1507533107-2069-3-git-send-email-caoj.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507533107-2069-3-git-send-email-caoj.fnst@cn.fujitsu.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote: > As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is > used to add arch-specific options for $(CC). From commandline, > CFLAGS_MODULE shall be used. > Doesn't have any functional change, but just follow kbuild rules. > > Signed-off-by: Cao jin > CC: Richard Kuo > CC: linux-hexagon@vger.kernel.org > --- > arch/hexagon/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile > index 207711a0..4f5c84c 100644 > --- a/arch/hexagon/Makefile > +++ b/arch/hexagon/Makefile > @@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums > > # Modules must use either long-calls, or use pic/plt. > # Use long-calls for now, it's easier. And faster. > -# CFLAGS_MODULE += -fPIC > -# LDFLAGS_MODULE += -shared > -CFLAGS_MODULE += -mlong-calls > +# KBUILD_CFLAGS_MODULE += -fPIC > +# KBUILD_LDFLAGS_MODULE += -shared > +KBUILD_CFLAGS_MODULE += -mlong-calls > > cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION}) > aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION}) > -- > 2.1.0 > > > For Hexagon: Acked-by: Richard Kuo -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project