From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, mark.rutland@arm.com,
robh@kernel.org, will.deacon@arm.com, sudeep.holla@arm.com,
frowand.list@gmail.com, devicetree@vger.kernel.org,
Jonathan.Cameron@huawei.com, marc.zyngier@arm.com,
peterz@infradead.org, mathieu.poirier@linaro.org,
leo.yan@linaro.org, Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: [PATCH v8 2/8] of: Add helper for mapping device node to logical CPU number
Date: Tue, 10 Oct 2017 11:32:57 +0100 [thread overview]
Message-ID: <20171010103303.32436-3-suzuki.poulose@arm.com> (raw)
In-Reply-To: <20171010103303.32436-1-suzuki.poulose@arm.com>
Add a helper to map a device node to a logical CPU number to avoid
duplication. Currently this is open coded in different places (e.g
gic-v3, coresight). The helper tries to map device node to a "possible"
logical CPU id, which may not be online yet. It is the responsibility
of the user to make sure that the CPU is online. The helper uses
of_cpu_device_node_get() to retrieve the device node for a given CPU
(which uses per_cpu data if available else falls back to slower
of_get_cpu_node()).
Cc: devicetree@vger.kernel.org
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
Changes since V6:
- Use faster of_cpu_device_node_get instead of of_get_cpu_node(),
which now falls back to latter if called in early.
Changes since V3:
- Renamed the helper to of_cpu_node_to_id(), suggested by Rob
- Return -ENODEV on failure than nr_cpus_id
---
drivers/of/base.c | 26 ++++++++++++++++++++++++++
include/linux/of.h | 7 +++++++
2 files changed, 33 insertions(+)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 260d33c0f26c..e3f46daeee07 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -418,6 +418,32 @@ struct device_node *of_get_cpu_node(int cpu, unsigned int *thread)
EXPORT_SYMBOL(of_get_cpu_node);
/**
+ * of_cpu_node_to_id: Get the logical CPU number for a given device_node
+ *
+ * @cpu_node: Pointer to the device_node for CPU.
+ *
+ * Returns the logical CPU number of the given CPU device_node.
+ * Returns -ENODEV if the CPU is not found.
+ */
+int of_cpu_node_to_id(struct device_node *cpu_node)
+{
+ int cpu;
+ bool found = false;
+ struct device_node *np;
+
+ for_each_possible_cpu(cpu) {
+ np = of_cpu_device_node_get(cpu);
+ found = (cpu_node == np);
+ of_node_put(np);
+ if (found)
+ return cpu;
+ }
+
+ return -ENODEV;
+}
+EXPORT_SYMBOL(of_cpu_node_to_id);
+
+/**
* __of_device_is_compatible() - Check if the node matches given constraints
* @device: pointer to node
* @compat: required compatible string, NULL or "" for any match
diff --git a/include/linux/of.h b/include/linux/of.h
index cfc34117fc92..27b54bcc420a 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -538,6 +538,8 @@ const char *of_prop_next_string(struct property *prop, const char *cur);
bool of_console_check(struct device_node *dn, char *name, int index);
+extern int of_cpu_node_to_id(struct device_node *np);
+
#else /* CONFIG_OF */
static inline void of_core_init(void)
@@ -862,6 +864,11 @@ static inline void of_property_clear_flag(struct property *p, unsigned long flag
{
}
+static inline int of_cpu_node_to_id(struct device_node *np)
+{
+ return -ENODEV;
+}
+
#define of_match_ptr(_ptr) NULL
#define of_match_node(_matches, _node) NULL
#endif /* CONFIG_OF */
--
2.13.6
next prev parent reply other threads:[~2017-10-10 10:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 10:32 [PATCH v8 0/8] perf: Support for ARM DynamIQ Shared Unit Suzuki K Poulose
2017-10-10 10:32 ` [PATCH v8 1/8] perf: Export perf_event_update_userpage Suzuki K Poulose
2017-10-10 10:32 ` Suzuki K Poulose [this message]
2017-10-10 10:32 ` [PATCH v8 3/8] coresight: of: Use of_cpu_node_to_id helper Suzuki K Poulose
2017-10-10 10:32 ` [PATCH v8 4/8] irqchip: gic-v3: " Suzuki K Poulose
2017-10-10 10:33 ` [PATCH v8 5/8] arm64: Use of_cpu_node_to_id helper for CPU topology parsing Suzuki K Poulose
2017-10-17 15:24 ` Mark Rutland
2017-10-17 16:11 ` Will Deacon
2017-10-17 16:20 ` Suzuki K Poulose
2017-10-17 16:42 ` Suzuki K Poulose
2017-10-10 10:33 ` [PATCH v8 6/8] arm_pmu: Use of_cpu_node_to_id helper Suzuki K Poulose
2017-10-17 15:26 ` Mark Rutland
2017-10-10 10:33 ` [PATCH v8 7/8] dt-bindings: Document devicetree binding for ARM DSU PMU Suzuki K Poulose
2017-10-18 9:20 ` Mark Rutland
2017-10-10 10:33 ` [PATCH v8 8/8] perf: ARM DynamIQ Shared Unit PMU support Suzuki K Poulose
2017-10-18 9:20 ` Mark Rutland
2017-10-20 10:17 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010103303.32436-3-suzuki.poulose@arm.com \
--to=suzuki.poulose@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®