From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756026AbdJJLdg (ORCPT ); Tue, 10 Oct 2017 07:33:36 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:48626 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755221AbdJJLdf (ORCPT ); Tue, 10 Oct 2017 07:33:35 -0400 Date: Tue, 10 Oct 2017 13:33:21 +0200 From: Peter Zijlstra To: Cheng Jian Cc: mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, xiexiuqi@huawei.com, huawei.libin@huawei.com, Steven Rostedt , Jiri Olsa Subject: Re: [PATCH] perf/ftrace : Fix repetitious traces when specify a target task Message-ID: <20171010113321.rq7w2kb77vyf6qoj@hirez.programming.kicks-ass.net> References: <1507598379-148309-1-git-send-email-cj.chengjian@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507598379-148309-1-git-send-email-cj.chengjian@huawei.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 10, 2017 at 09:19:39AM +0800, Cheng Jian wrote: > diff --git a/kernel/events/core.c b/kernel/events/core.c > index baa134c..5682ead 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -7988,12 +7988,16 @@ void perf_tp_event(u16 event_type, u64 count, void *record, int entry_size, > > /* Use the given event instead of the hlist */ > if (event) { > - if (perf_tp_event_match(event, &data, regs)) > + if (perf_tp_event_match(event, &data, regs)) { > perf_swevent_event(event, count, &data, regs); > + goto out; > + } > } else { > hlist_for_each_entry_rcu(event, head, hlist_entry) { > - if (perf_tp_event_match(event, &data, regs)) > + if (perf_tp_event_match(event, &data, regs)) { > perf_swevent_event(event, count, &data, regs); > + goto out; > + } > } > } > > @@ -8015,13 +8019,15 @@ void perf_tp_event(u16 event_type, u64 count, void *record, int entry_size, > continue; > if (event->attr.config != entry->type) > continue; > - if (perf_tp_event_match(event, &data, regs)) > + if (perf_tp_event_match(event, &data, regs)) { > perf_swevent_event(event, count, &data, regs); > + break; > + } > } > unlock: > rcu_read_unlock(); > } > - > +out: > perf_swevent_put_recursion_context(rctx); > } > EXPORT_SYMBOL_GPL(perf_tp_event); No, this _cannot_ be right. The whole point of the @task argument was to deliver the event multiple times -- maybe not to the same event, but it needs to be delivered multiple times in some cases. Therefore this is broken. But now you've got me looking at 75e8387685f6, which also looks completely insane.