mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org,
	zhouchengming1@huawei.com
Subject: Re: [PATCH 1/3] perf/ftrace: Revert ("perf/ftrace: Fix double traces of perf on ftrace:function")
Date: Tue, 10 Oct 2017 15:26:44 -0400	[thread overview]
Message-ID: <20171010152644.432eae77@gandalf.local.home> (raw)
In-Reply-To: <20171010163607.498635023@infradead.org>

On Tue, 10 Oct 2017 18:31:25 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> Revert commit:
> 
>   75e8387685f6 ("perf/ftrace: Fix double traces of perf on ftrace:function")
> 
> The reason I insta stumbled on that patch is that it only addresses the ftrace

I'm trying to figure out what you meant by "insta".

-- Steve

> situation and doesn't mention the other _5_ places that use this interface. It
> doesn't explain why those don't have the problem and if not, why their solution
> doesn't work for ftrace.
> 
> It doesn't, but this is just putting more duct tape on.
> 
> Cc: Zhou Chengming <zhouchengming1@huawei.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>

  reply	other threads:[~2017-10-10 19:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 16:31 [PATCH 0/3] perf/ftrace: Sanitize perf function-trace interaction Peter Zijlstra
2017-10-10 16:31 ` [PATCH 1/3] perf/ftrace: Revert ("perf/ftrace: Fix double traces of perf on ftrace:function") Peter Zijlstra
2017-10-10 19:26   ` Steven Rostedt [this message]
2017-10-10 21:10     ` Peter Zijlstra
2017-10-10 16:31 ` [PATCH 2/3] perf/ftrace: Fix function trace events Peter Zijlstra
2017-10-10 19:43   ` Steven Rostedt
2017-10-10 21:07     ` Peter Zijlstra
2017-10-10 16:31 ` [PATCH 3/3] ftrace: Kill FTRACE_OPS_FL_PER_CPU Peter Zijlstra
2017-10-10 16:40 ` [PATCH 0/3] perf/ftrace: Sanitize perf function-trace interaction Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171010152644.432eae77@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=zhouchengming1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®