From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757818AbdJKTIz (ORCPT ); Wed, 11 Oct 2017 15:08:55 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34810 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514AbdJKTIy (ORCPT ); Wed, 11 Oct 2017 15:08:54 -0400 Date: Wed, 11 Oct 2017 12:08:51 -0700 (PDT) Message-Id: <20171011.120851.1428660689178106234.davem@davemloft.net> To: joel@jms.id.au Cc: benh@kernel.crashing.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@aj.id.au Subject: Re: [PATCH] net: ftgmac100: Request clock and set speed From: David Miller In-Reply-To: <20171010044925.21078-1-joel@jms.id.au> References: <20171010044925.21078-1-joel@jms.id.au> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Oct 2017 12:08:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joel Stanley Date: Tue, 10 Oct 2017 15:19:25 +1030 > According to the ASPEED datasheet, gigabit speeds require a clock of > 100MHz or higher. Other speeds require 25MHz or higher. > > Signed-off-by: Joel Stanley Hey Joel, it seems that Benjamin would like you to guard this new logic with whether we have an aspeed configuration or not. Thank you.