From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757495AbdJKVCH (ORCPT ); Wed, 11 Oct 2017 17:02:07 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36620 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbdJKVCE (ORCPT ); Wed, 11 Oct 2017 17:02:04 -0400 Date: Wed, 11 Oct 2017 14:02:03 -0700 (PDT) Message-Id: <20171011.140203.578840078366210432.davem@davemloft.net> To: madalin.bucur@nxp.com Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, junote@outlook.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] dpaa_eth: change device used From: David Miller In-Reply-To: <1507644618-32006-4-git-send-email-madalin.bucur@nxp.com> References: <1507644618-32006-1-git-send-email-madalin.bucur@nxp.com> <1507644618-32006-4-git-send-email-madalin.bucur@nxp.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Oct 2017 14:02:04 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Madalin Bucur Date: Tue, 10 Oct 2017 17:10:17 +0300 > @@ -2696,7 +2681,13 @@ static int dpaa_eth_probe(struct platform_device *pdev) > int err = 0, i, channel; > struct device *dev; > > - dev = &pdev->dev; > + /* device used for DMA mapping */ > + dev = pdev->dev.parent; > + err = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(40)); > + if (err) { > + dev_err(dev, "dma_coerce_mask_and_coherent() failed\n"); > + goto dev_mask_failed; > + } > > /* Allocate this early, so we can store relevant information in > * the private area Since you are moving this code up before the netdev allocation, you must adjust the failure path goto label used. Your change as-is will cause an OOPS because we'll pass a NULL pointer to free_netdev().