From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753218AbdJLDNV (ORCPT ); Wed, 11 Oct 2017 23:13:21 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41956 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752982AbdJLDNT (ORCPT ); Wed, 11 Oct 2017 23:13:19 -0400 Date: Wed, 11 Oct 2017 20:13:19 -0700 (PDT) Message-Id: <20171011.201319.1327623357814721573.davem@davemloft.net> To: sam@mendozajonas.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net/ncsi: Don't limit vids based on hot_channel From: David Miller In-Reply-To: <20171011055427.30227-1-sam@mendozajonas.com> References: <20171011055427.30227-1-sam@mendozajonas.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Oct 2017 20:13:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Samuel Mendoza-Jonas Date: Wed, 11 Oct 2017 16:54:27 +1100 > Currently we drop any new VLAN ids if there are more than the current > (or last used) channel can support. Most importantly this is a problem > if no channel has been selected yet, resulting in a segfault. > > Secondly this does not necessarily reflect the capabilities of any other > channels. Instead only drop a new VLAN id if we are already tracking the > maximum allowed by the NCSI specification. Per-channel limits are > already handled by ncsi_add_filter(), but add a message to set_one_vid() > to make it obvious that the channel can not support any more VLAN ids. > > Signed-off-by: Samuel Mendoza-Jonas Applied, thanks.