From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757405AbdJKM56 (ORCPT ); Wed, 11 Oct 2017 08:57:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:46444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752007AbdJKM54 (ORCPT ); Wed, 11 Oct 2017 08:57:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FFAC21874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 11 Oct 2017 08:57:54 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, zhouchengming1@huawei.com Subject: Re: [PATCH 1/4] perf/ftrace: Revert ("perf/ftrace: Fix double traces of perf on ftrace:function") Message-ID: <20171011085754.7ae0f153@gandalf.local.home> In-Reply-To: <20171011080224.200565770@infradead.org> References: <20171011074528.764500836@infradead.org> <20171011080224.200565770@infradead.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Oct 2017 09:45:29 +0200 Peter Zijlstra wrote: > Revert commit: > > 75e8387685f6 ("perf/ftrace: Fix double traces of perf on ftrace:function") > > The reason I instantly stumbled on that patch is that it only addresses the > ftrace situation and doesn't mention the other _5_ places that use this > interface. It doesn't explain why those don't have the problem and if not, why > their solution doesn't work for ftrace. > > It doesn't, but this is just putting more duct tape on. > > Cc: Zhou Chengming > Cc: Jiri Olsa > Cc: Steven Rostedt (VMware) > Cc: Ingo Molnar > Signed-off-by: Peter Zijlstra (Intel) Acked-by: Steven Rostedt (VMware) -- Steve