From: Punit Agrawal <punit.agrawal@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Punit Agrawal <punit.agrawal@arm.com>,
marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] GICv3: Bounds check redistributor accesses
Date: Wed, 11 Oct 2017 10:41:45 +0100 [thread overview]
Message-ID: <20171011094148.15674-1-punit.agrawal@arm.com> (raw)
Hi,
While bringing up linux on a platform with GICv3, I ran into a kernel
crash (data abort) due to incorrectly sized GIC redistributor region
in the device tree.
Even though the firmware is expected to provide incorrect information,
crashing on the kernel's part when that is not the case is also not
ideal.
This series adds bounds checking to redistributor accesses. This
prevents the crash. But we can do one better - when the redistributor
region has been exhausted without encountering the last record the
user is warned of this situation. This can be useful for developers
during board bring-up.
Patch 3 is where the bulk of the checking is introduced. The patch is
a bit invasive but there doesn't seem to be a nicer way to isolate the
change given layout of the redistributor.
Feedback welcome.
Thanks,
Punit
Punit Agrawal (3):
irqchip/gic-v3: Use resource structure to store redistributor regions
irqchip/gic-v3: Report firmwware provided address in case of error
irqchip/gic-v3: Bounds check redistributor accesses
drivers/irqchip/irq-gic-v3.c | 80 +++++++++++++++++++++++++++++++++-----------
1 file changed, 61 insertions(+), 19 deletions(-)
--
2.14.1
next reply other threads:[~2017-10-11 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 9:41 Punit Agrawal [this message]
2017-10-11 9:41 ` [PATCH 1/3] irqchip/gic-v3: Use resource structure to store redistributor regions Punit Agrawal
2017-10-11 9:41 ` [PATCH 2/3] irqchip/gic-v3: Report firmwware provided address in case of error Punit Agrawal
2017-10-11 9:41 ` [PATCH 3/3] irqchip/gic-v3: Bounds check redistributor accesses Punit Agrawal
2018-03-13 13:38 ` [3/3] " Lokesh Vutla
2018-03-13 14:21 ` Marc Zyngier
2018-03-13 18:49 ` Nishanth Menon
2018-03-13 20:19 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011094148.15674-1-punit.agrawal@arm.com \
--to=punit.agrawal@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®