From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753046AbdJKJ5h (ORCPT ); Wed, 11 Oct 2017 05:57:37 -0400 Received: from mail.skyhub.de ([5.9.137.197]:37258 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbdJKJ5g (ORCPT ); Wed, 11 Oct 2017 05:57:36 -0400 Date: Wed, 11 Oct 2017 11:57:26 +0200 From: Borislav Petkov To: Tom Lendacky Cc: x86@kernel.org, Peter Zijlstra , linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner Subject: Re: [PATCH] x86/mm: Disable various instrumentations of mem_encrypt.c Message-ID: <20171011095726.fzilylt32rpmkson@pd.tnic> References: <20171010194504.18887.38053.stgit@tlendack-t1.amdoffice.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171010194504.18887.38053.stgit@tlendack-t1.amdoffice.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 10, 2017 at 02:45:04PM -0500, Tom Lendacky wrote: > Some routines in mem_encrypt.c are called very early in the boot process, > e.g. sme_enable(). When CONFIG_KCOV is defined the resulting code added > to sme_enable() (and others) for KCOV instrumentation results in a kernel > crash. Disable the KCOV instrumentation for mem_encrypt.c by adding > KCOV_INSTRUMENT_mem_encrypt.o := n to arch/x86/mm/Makefile. > > In order to avoid other possible early boot issues, model mem_encrypt.c > after head64.c in regards to tools. In addition to disabling KCOV as > stated above and a previous patch that disables branch profiling, also > remove the "-pg" CFLAG if CONFIG_FUNCTION_TRACER is enabled and set > KASAN_SANITIZE to "n", each of which are done on a file basis. > > Reported-by: kernel test robot > Signed-off-by: Tom Lendacky > --- > arch/x86/mm/Makefile | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.