From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752294AbdJKLPi (ORCPT ); Wed, 11 Oct 2017 07:15:38 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:22112 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbdJKLPf (ORCPT ); Wed, 11 Oct 2017 07:15:35 -0400 X-AuditID: b6c32a37-c75ff70000001076-ac-59ddfd54860b Mime-Version: 1.0 Subject: RE: [PATCH v3 3/8] PM / devfreq: Show the available min/max frequency through sysfs node Reply-To: myungjoo.ham@samsung.com From: MyungJoo Ham To: Chanwoo Choi , Kyungmin Park CC: "rafael.j.wysocki@intel.com" , "chanwoo@kernel.org" , Inki Dae , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <1507691364-3899-4-git-send-email-cw00.choi@samsung.com> X-Drm-Type: N,general X-EPLocale: ko_KR.EUC-KR X-EPWebmail-Msg-Type: personal X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Illegal-Object: Syntax error in X-Sender: address found on vger.kernel.org: X-Sender: =?utf-8?B?U2Ftc3VuZyBFbGVjdHJvbmljcxtBcnRpZmljaWFsIEludA==?= ^-Extraneous program text X-Sender-IP: 10.113.73.204 X-Local-Sender: =?UTF-8?B?7ZWo66qF7KO8G0FydGlmaWNpYWwgSW50ZWxsaWdlbmNlIDNMYWIoUy9X?= =?UTF-8?B?7IS87YSwKRvsgrzshLHsoITsnpAbUHJpbmNpcGFsIEVuZ2lu?= =?UTF-8?B?ZWVy?= X-Global-Sender: =?UTF-8?B?TXl1bmdKb28gSGFtG0FydGlmaWNpYWwgSW50ZWxsaWdlbmNlIDNMYWIu?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbUHJpbmNpcGFsIEVuZ2lu?= =?UTF-8?B?ZWVy?= X-Sender-Code: =?UTF-8?B?QzEwGxtDMTBWODI5MQ==?= Message-ID: <20171011111532epcms1p3036bcc7be2cc00057fe478fc868ba71d@epcms1p3> Date: Wed, 11 Oct 2017 11:15:32 +0000 X-CMS-MailID: 20171011111532epcms1p3036bcc7be2cc00057fe478fc868ba71d Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-MTR: 20171011111532epcms1p3036bcc7be2cc00057fe478fc868ba71d CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkk+LIzCtJLcpLzFFi42LZdljTQDfk791Ig9a52hYTb1xhsbj+5Tmr xaT7E1gszja9Ybe4vGsOm8Xn3iOMFo9XvGV3YPdYvOclk8emVZ1sHn1bVjF6fN4kF8ASlWqT kZqYklqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA3SBkkJZYk4p UCggsbhYSd/Opii/tCRVISO/uMRWKdrQ0EjP0MBcz8jISM/EONbKyBSoJCE1Y8PX18wFpwQr pjf+YWtgPMbXxcjJISFgIvFvzWzWLkYuDiGBHYwSjzf9Zeti5ODgFRCU+LtDGKRGWCBZYur/ JlYQW0hASaLh5j5miLi+RMeDbYwgNpuArsTWDXdZQGwRgVCJ3Qv6wGqYBVqZJPZPSILYxSsx o/0pC4QtLbF9+VawXk4BV4lXTc/ZIeKiEjdXv4WyJSTuvL7ABGHLSUz7uoYZpub9sfmMELaI ROu9s1BxQYkHP3czgvwiIdDKKHFnyzOoQVIStxZfY4JILGOUWHz5KTuEs5xRon3JRrCPJYDe 2bndGeJ5X4ljOypBelkEVCVmXTjDBjHHRWLfrgaox+Qltr+dwwxSziygKbF+lz5Eia3E9cl3 WCBK+CTefe1hhfl9x7wnUL+oSRzavYR9AqPyLERIz0IydBbC0AWMzKsYxVILinPTU4sNC4z1 ihNzi0vz0vWS83M3MYKToZb5DsYN53wOMQpwMCrx8O64cidSiDWxrLgy9xCjBAezkggvGzCV CvGmJFZWpRblxxeV5qQWH2I0BfptIrOUaHI+MFHnlcQbmlgamJgZAVOcpaGhkjiv2PprEUIC 6YklqdmpqQWpRTB9TBycUg2MRmIu3Yeb37662d3kfYzj44dspoI8/RksPQ5L9ZfKb78azmak tyWxNKggcMcv9WDNJq4d02+fOSr/z+HovbBzjTaB3tN2tZmFLjmsIfbs4xT5CkWFP5uyRax+ OsmJqm5YK2ps1ND77aDxYX0x1bfFZ8+EJ3P++bEi4edHhlsTXjhxKJyeXtimxFKckWioxVxU nAgAhArAK5wDAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171011030946epcas1p40f32955da5dada46e95302701a0afb7d X-RootMTR: 20171011030946epcas1p40f32955da5dada46e95302701a0afb7d References: <1507691364-3899-4-git-send-email-cw00.choi@samsung.com> <1507691364-3899-1-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The existing {min|max}_freq sysfs nodes don't consider whether min/max_freq > are available or not. Those sysfs nodes show just the stored value > in the struct devfreq. > > The devfreq uses the OPP interface and then dev_pm_opp_{disable|add}() > might change the state of the device's supported frequency. This patch > shows the available minimum and maximum frequency through sysfs node. > > Signed-off-by: Chanwoo Choi > --- > drivers/devfreq/devfreq.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 2ce1fd0a1324..799a0cf75d39 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -1128,7 +1128,14 @@ static ssize_t min_freq_store(struct device *dev, struct device_attribute *attr, > static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr, > char *buf) > { > - return sprintf(buf, "%lu\n", to_devfreq(dev)->min_freq); > + struct devfreq *df = to_devfreq(dev); > + unsigned long min_freq = to_devfreq(dev)->min_freq; > + unsigned long available_min_freq = find_available_min_freq(df); > + > + if (available_min_freq != 0 && min_freq < available_min_freq) nitpick: If available_min_freq == 0, it can't be min_freq < available_min_freq anyway; it's unsigned. > + min_freq = available_min_freq; > + > + return sprintf(buf, "%lu\n", min_freq); > } > > static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr, > @@ -1162,7 +1169,14 @@ static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr, > static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr, > char *buf) > { > - return sprintf(buf, "%lu\n", to_devfreq(dev)->max_freq); > + struct devfreq *df = to_devfreq(dev); > + unsigned long max_freq = to_devfreq(dev)->max_freq; > + unsigned long available_max_freq = find_available_max_freq(df); > + > + if (available_max_freq != 0 && max_freq > available_max_freq) > + max_freq = available_max_freq; similar here. > + > + return sprintf(buf, "%lu\n", max_freq); > } > static DEVICE_ATTR_RW(max_freq);