From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757082AbdJKLjh (ORCPT ); Wed, 11 Oct 2017 07:39:37 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:37517 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbdJKLjg (ORCPT ); Wed, 11 Oct 2017 07:39:36 -0400 Date: Wed, 11 Oct 2017 07:39:07 -0400 From: Neil Horman To: Colin King Cc: Vlad Yasevich , "David S . Miller" , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] sctp: make array sctp_sched_ops static Message-ID: <20171011113906.GA5546@hmswarspite.think-freely.org> References: <20171011101757.18825-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171011101757.18825-1-colin.king@canonical.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2017 at 11:17:57AM +0100, Colin King wrote: > From: Colin Ian King > > The array sctp_sched_ops is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'sctp_sched_ops' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > net/sctp/stream_sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sctp/stream_sched.c b/net/sctp/stream_sched.c > index 03513a9fa110..0b83ec51e43b 100644 > --- a/net/sctp/stream_sched.c > +++ b/net/sctp/stream_sched.c > @@ -124,7 +124,7 @@ static struct sctp_sched_ops sctp_sched_fcfs = { > extern struct sctp_sched_ops sctp_sched_prio; > extern struct sctp_sched_ops sctp_sched_rr; > > -struct sctp_sched_ops *sctp_sched_ops[] = { > +static struct sctp_sched_ops *sctp_sched_ops[] = { > &sctp_sched_fcfs, > &sctp_sched_prio, > &sctp_sched_rr, > -- > 2.14.1 > > Acked-by: Neil Horman