From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752324AbdJKNRh (ORCPT ); Wed, 11 Oct 2017 09:17:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:44553 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbdJKNRg (ORCPT ); Wed, 11 Oct 2017 09:17:36 -0400 Date: Wed, 11 Oct 2017 15:17:32 +0200 From: Michal Hocko To: "Levin, Alexander (Sasha Levin)" Cc: "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "vegardno@ifi.uio.no" , "penberg@kernel.org" , "ebiederm@xmission.com" , "glider@google.com" , "devtimhansen@gmail.com" Subject: Re: [PATCH v2 1/4] kmemcheck: remove annotations Message-ID: <20171011131732.kfx53yvgfqbufiqi@dhcp22.suse.cz> References: <20171007030159.22241-1-alexander.levin@verizon.com> <20171007030159.22241-2-alexander.levin@verizon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171007030159.22241-2-alexander.levin@verizon.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 07-10-17 03:02:13, Sasha Levin wrote: > Remove kmemcheck annotations, and calls to kmemcheck from the kernel. How did you generate this? I suspect a git grep + sed? Because this doesn't seem to be correct. I didn't get further than this > @@ -266,7 +264,6 @@ static inline int dma_map_sg_attrs(struct device *dev, struct scatterlist *sg, > struct scatterlist *s; > > for_each_sg(sg, s, nents, i) > - kmemcheck_mark_initialized(sg_virt(s), s->length); > BUG_ON(!valid_dma_direction(dir)); > ents = ops->map_sg(dev, sg, nents, dir, attrs); > BUG_ON(ents < 0); which doesn't really look correct. I appreciate you have split this up and the resulting code might even be correct I find it quite important to have such a large changes be reproducible by reviewers because it is simply impossible to review this manually. -- Michal Hocko SUSE Labs