From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbdJKNpC (ORCPT ); Wed, 11 Oct 2017 09:45:02 -0400 Received: from fieldses.org ([173.255.197.46]:41510 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbdJKNpA (ORCPT ); Wed, 11 Oct 2017 09:45:00 -0400 Date: Wed, 11 Oct 2017 09:45:00 -0400 From: "J. Bruce Fields" To: David Howells Cc: Jia-Ju Bai , Jeff Layton , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/afs/flock and fs/locks: Fix possible sleep-in-atomic bugs in posix_lock_file Message-ID: <20171011134500.GB25913@fieldses.org> References: <20171008010758.GA23643@fieldses.org> <1507370104-21751-1-git-send-email-baijiaju1990@163.com> <1507372617.26934.0.camel@redhat.com> <17920.1507715263@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17920.1507715263@warthog.procyon.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2017 at 10:47:43AM +0100, David Howells wrote: > J. Bruce Fields wrote: > > > Does that mean nobody's tested fcntl locking over afs since that change in > > 2010? > > Quite feasibly not. I've been beating kAFS into shape and I'm aware of the > lock thing. It's on the list after getting the core server rotation working > properly since that will affect a whole bunch of code, including the locking > code. > > I've more or less finished the server rotation bit. See: > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-2-experimental Neat! Well, pending a real fix I suppose it's probably clearest to leave the locking code in an obviously broken state. Might be worth a comment though. --b.