From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752835AbdJKNsR (ORCPT ); Wed, 11 Oct 2017 09:48:17 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:50414 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbdJKNsP (ORCPT ); Wed, 11 Oct 2017 09:48:15 -0400 From: Arnd Bergmann To: Marcel Holtmann , Gustavo Padovan , Johan Hedberg Cc: Hans de Goede , Arnd Bergmann , Sebastian Reichel , Tobias Regnery , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] Bluetooth: BT_HCIUART now depends on SERIAL_DEV_BUS Date: Wed, 11 Oct 2017 15:47:54 +0200 Message-Id: <20171011134805.3207569-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20171011134640.3152236-1-arnd@arndb.de> References: <20171011134640.3152236-1-arnd@arndb.de> X-Provags-ID: V03:K0:+ZIc6mjT09LVenQ6H//YgZrfPILdOAXLNMPfDuPnTmb/b8NGgjC Dj+yDbSk6YOA5y3h8Nab7A+sWmYNu8Rb0pYGSbF7u2H3giP5SVVuHN6z0y6ROTvaMOufE8S ZN6eB7gwFpHI6mKMbl/nRZ5qYgJowWOb3xFe6wFBz0ZApNFM9SgxaEwHEKxpOHEpruwlUOE jN9zPAhejucw7pETyW0UQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:un9sBsKyTFA=:yqjvByPUgQWHD3/hLg5Skm Vl3xAXIL0uTq6tThbka8XxOPyJBlzpxCKzqW4PlS5XWU3zJad+M3PedUsouA/uJK0TAbCsItX qkvSONyIZqqdzmURqaGYhFX6uqE/+vRTyoZlh1ya2pD+GIRMBVUizWWUwK7tjFdWTuG19EVaF odEDztGCUisYLcD+VlHPn9Sw+sqFqQBouHPYMUANjstmb7m79SMK3umL6K1pM2//XyKBgCALr CM3VFFqyr9sa1efmpoJMM3Jp2lwo6VP86ggbkIBWH7t/iGhFPZrOnFNhJ86rXOgkrUweEfGrr S9tLgvGtws0v6VfZWROSoQNw17fLzeU42EYKKozjG+1E3047oALerN5hr6pNaIuIUYnsxFE+O JnbeMKDLEFKeJF6oRnUSzd11s89mwvGcf7cJyoFSBw+3w10REFB/E4pClxcyNdhSU3kmGxVmq P8U34+0/CdH/cW6fobtt1cuVX2hsdnKSujsDslW6kRDyUKYxUhG6LII/1aGWok7kzO/05qGSJ jbc0qDSp8Le8H3958aSjkadoBUj5B4T3ourmwrgcqUa1xtiJ7hLOkMw9LcnGcQimkJS8L/N7s 3qOqWDyDJmd455U8zE51dn2dMai+mt5wEKRrgm+Onz9y0K5jqBEdwuYIaP81nF1WV7l1EcqTw b/WkY2JFzbvfhMTXTMUURTf8y6XwhLhRt5BFHY2SDmDz51LePjUFuzGRB8dywJstWv2VU9qi+ Z5sN3Miz/D9HgaBxT8kIx9qs1mZ9o+7bwz72lg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is no longer possible to build BT_HCIUART into the kernel when SERIAL_DEV_BUS is a loadable module, even if none of the SERIAL_DEV_BUS based implementations are selected: drivers/bluetooth/hci_ldisc.o: In function `hci_uart_set_flow_control': hci_ldisc.c:(.text+0xb40): undefined reference to `serdev_device_set_flow_control' hci_ldisc.c:(.text+0xb5c): undefined reference to `serdev_device_set_tiocm' This adds a dependency to avoid the broken configuration. Fixes: 7841d554809b ("Bluetooth: hci_uart_set_flow_control: Fix NULL deref when using serdev") Signed-off-by: Arnd Bergmann --- drivers/bluetooth/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index fae5a74dc737..4427d54b7331 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -65,6 +65,7 @@ config BT_HCIBTSDIO config BT_HCIUART tristate "HCI UART driver" + depends on SERIAL_DEV_BUS || !SERIAL_DEV_BUS depends on TTY help Bluetooth HCI UART driver. @@ -79,7 +80,6 @@ config BT_HCIUART config BT_HCIUART_SERDEV bool depends on SERIAL_DEV_BUS && BT_HCIUART - depends on SERIAL_DEV_BUS=y || SERIAL_DEV_BUS=BT_HCIUART default y config BT_HCIUART_H4 -- 2.9.0