From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbdJKOJB (ORCPT ); Wed, 11 Oct 2017 10:09:01 -0400 Received: from omzsmtpe01.verizonbusiness.com ([199.249.25.210]:31144 "EHLO omzsmtpe01.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752547AbdJKOI5 (ORCPT ); Wed, 11 Oct 2017 10:08:57 -0400 From: "Levin, Alexander (Sasha Levin)" X-Host: mariner.tdc.vzwcorp.com To: Michal Hocko CC: "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "vegardno@ifi.uio.no" , "penberg@kernel.org" , "ebiederm@xmission.com" , "glider@google.com" , "devtimhansen@gmail.com" Subject: Re: [PATCH v2 1/4] kmemcheck: remove annotations Thread-Topic: [PATCH v2 1/4] kmemcheck: remove annotations Thread-Index: AQHTQpo1GJ6PraHoU0myRsYYDhj6UQ== Date: Wed, 11 Oct 2017 14:07:02 +0000 Message-ID: <20171011140659.pud73efdfk6ib34u@sasha-lappy> References: <20171007030159.22241-1-alexander.levin@verizon.com> <20171007030159.22241-2-alexander.levin@verizon.com> <20171011131732.kfx53yvgfqbufiqi@dhcp22.suse.cz> In-Reply-To: <20171011131732.kfx53yvgfqbufiqi@dhcp22.suse.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: NeoMutt/20170113 (1.7.2) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="us-ascii" Content-ID: <80C3748AD0E93E47B1131A80C5A295A4@vzwcorp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9BE94cn016670 On Wed, Oct 11, 2017 at 03:17:32PM +0200, Michal Hocko wrote: >On Sat 07-10-17 03:02:13, Sasha Levin wrote: >> Remove kmemcheck annotations, and calls to kmemcheck from the kernel. > >How did you generate this? I suspect a git grep + sed? Because this >doesn't seem to be correct. I didn't get further than this I had an (apparently broken) Coccinelle script to remove references to kmemcheck hooks. >> @@ -266,7 +264,6 @@ static inline int dma_map_sg_attrs(struct device *dev, struct scatterlist *sg, >> struct scatterlist *s; >> >> for_each_sg(sg, s, nents, i) >> - kmemcheck_mark_initialized(sg_virt(s), s->length); >> BUG_ON(!valid_dma_direction(dir)); >> ents = ops->map_sg(dev, sg, nents, dir, attrs); >> BUG_ON(ents < 0); > >which doesn't really look correct. I appreciate you have split this up >and the resulting code might even be correct I find it quite important >to have such a large changes be reproducible by reviewers because it is >simply impossible to review this manually. Let me send a fix for that, and review this again. Thanks for the review! >-- >Michal Hocko >SUSE Labs -- Thanks, Sasha