From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757887AbdJKQcF (ORCPT ); Wed, 11 Oct 2017 12:32:05 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36183 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757701AbdJKQcD (ORCPT ); Wed, 11 Oct 2017 12:32:03 -0400 X-Google-Smtp-Source: AOwi7QDTwOQTAP/9TTsfAU/40rN2bTMGsgJpnaid1baA0UgpNMolq5VL9rmffZc2OLsJwe0aYOseTg== Date: Wed, 11 Oct 2017 18:31:59 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Mario Limonciello Cc: dvhart@infradead.org, Andy Shevchenko , LKML , platform-driver-x86@vger.kernel.org, Andy Lutomirski , quasisec@google.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de, Greg KH Subject: Re: [PATCH v7 04/15] platform/x86: dell-wmi: allow 32k return size in the descriptor Message-ID: <20171011163159.zhott3wh4fx6c76r@pali> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 11 October 2017 11:27:30 Mario Limonciello wrote: > Some platforms this year will be adopting 32k WMI buffer, so don't > complain when encountering those. > > Signed-off-by: Mario Limonciello > --- > drivers/platform/x86/dell-wmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > index ece2fe341f01..c8c7f4f9326c 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -624,7 +624,7 @@ static void dell_wmi_input_destroy(struct wmi_device *wdev) > * Vendor Signature 0 4 "DELL" > * Object Signature 4 4 " WMI" > * WMI Interface Version 8 4 > - * WMI buffer length 12 4 4096 > + * WMI buffer length 12 4 4096 or 32768 > */ > static int dell_wmi_check_descriptor_buffer(struct wmi_device *wdev) > { > @@ -674,7 +674,7 @@ static int dell_wmi_check_descriptor_buffer(struct wmi_device *wdev) > dev_warn(&wdev->dev, "Dell descriptor buffer has unknown version (%u)\n", > buffer[2]); > > - if (buffer[3] != 4096) > + if (desc_buffer[3] != 4096 && desc_buffer[3] != 32768) Looks like that desc_buffer is not declared. > dev_warn(&wdev->dev, "Dell descriptor buffer has invalid buffer length (%u)\n", > buffer[3]); > -- Pali Rohár pali.rohar@gmail.com