From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757706AbdJKToS (ORCPT ); Wed, 11 Oct 2017 15:44:18 -0400 Received: from mail-co1nam03on0070.outbound.protection.outlook.com ([104.47.40.70]:53184 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752347AbdJKToP (ORCPT ); Wed, 11 Oct 2017 15:44:15 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@cavium.com; Date: Wed, 11 Oct 2017 22:43:55 +0300 From: Yury Norov To: Eric Dumazet Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Catalin Marinas , "David S. Miller" , Florian Westphal Subject: Re: next: arm64: LTP sendto01 test causes system crash in ilp32 mode Message-ID: <20171011194355.n6mb4oe7qt76d6wh@yury-thinkpad> References: <20171011183522.tm2xxgzbdspjtsax@yury-thinkpad> <1507747313.31614.27.camel@edumazet-glaptop3.roam.corp.google.com> <1507747717.31614.28.camel@edumazet-glaptop3.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507747717.31614.28.camel@edumazet-glaptop3.roam.corp.google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Originating-IP: [176.59.118.210] X-ClientProxiedBy: AM5PR0102CA0036.eurprd01.prod.exchangelabs.com (2603:10a6:206::49) To CY4PR0701MB3826.namprd07.prod.outlook.com (2603:10b6:910:94::32) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1f44424-58c4-4f95-a8f9-08d510e072ec X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY4PR0701MB3826; X-Microsoft-Exchange-Diagnostics: 1;CY4PR0701MB3826;3:7jYtDQ/8lVdh+AdxdFWL8LFaFPgceton/jrFpx8k16GG+ug8CtVLRaWro8qhimeUDU01du9ruVlRkrcqxb0yaBzSjzbQH5AF+d/RK2vI+XUYC2Pfmaq63+86xeCkR5/PnyABiEXHQcUMOPtvVQ9HNxmpk/DK6CgttOu8DYs86WMhILUcx/xAQ+GpGy7MC+W5IaktzQEKr6sMvLoSj0ej+mKK8cF7Bjz/yE4MkoTLbyC9tyYagtWNvJ2nCJ9TX1Em;25:ABwN/kszE7LmXLpowX/wogFSov8H3YS55kInzqkt5gFfM2fBz2ygb2Qs/3vINuVMf/6DDgHDi4iD4t3JLWcg/OOndHend47iOC4+ZTpKSOcrGJJrdz7MATXxWw9PoVHHKyS0alkLwKPv01WWbPwzutrhDg7Pw7MncKNUth2nGUUsZXVE2j+HIcvPFDh1hQdpeW7Acb2UtZu0LaMJZH995tSO9V7yYtYXSLqODN+zzHQSHgq3YYlCW7eZcjDISKNlh4cWE/EEUoYuVXLLIzhJifoFXjZilo3lE1hwM3TpSYj9tReg6zYi88mxBl1CHEbTbwEOTf6dFzmAPCh7drYF8Q==;31:+qR93vCzEBc2BWEl5rvGI4kPiA414JO5djBDtMRD5uLhohb6DoA2lIvIZbRoXoiPq7l6d4bXVECCCN0WriUkC5KXQmVMfmrrWlGyeIRJp8ZrwJQ+5mDdY1P7mta2pyQolv5nmTjzZBq0I1p5TMfoeN9UD4pioKHa4SmAoAvA+8LOcXBX+bbnP2OXpg/RO4sdHay5OD3W3wKeqs9zjtQRVEmR9jNmSSLRCFD82a3P6zE= X-MS-TrafficTypeDiagnostic: CY4PR0701MB3826: X-Microsoft-Exchange-Diagnostics: 1;CY4PR0701MB3826;20:ixney1g/sdZQ5aVTvVcdzhalrHsv8mwWiWXqYujqVTY6vWMnjQ8DmRhih7fYhFIqW5GZ2mV/3FOBYYo8Z0CPP0yQVuQ9lOQu/r7c+ys1VcWAXSZytj3Y8M20l0SnWJx5kY3vUh+DAQ3iXn1T6UpkGS69bpVvcc8R4qRQVmVaImqbykvwE+bbXIQf05Ua/b3eAaCiDvORF105kLtFkFPFR9TH/VJajSycjgNBvdkAkXWPz9utzS9noYUsBsIamAASj5Gbg8fnjaD1DM4iz7eH8B5go+ZkZhVXsTF3jGG/bs+20tBfKKSz6ZhKLfdUFOf2UCq9iIjjwfl7lIGZe4OXZuMS1VeO58AxbJJFnibTM3WQKC3Fn45QUTNOPyreTT7pd8uec/YmgmK3hPeQfL48AF6UJ8nGuYP7G2gb63z396rR8Y6TkRR26XA17z88zJnq7scjuM7pYqGWpN/4ol2o5hXi3UKIKwIF5PcxiPeYiZSZTouEwC8YTP7ALfrv2l6Ia8gb4PVsDlQpYYdj+ml80waiul5PkBRuT/bXvbY5AfR9I6kyM9eVIstJ6CWpuo8tNHbjdgF6ykxxcyG7l4sK8fe37b3ztumIHJ/DcEGJzR8=;4:ECGbPpiOgak7X/1V0ev7Lz3Pwt62G60lLOYMNjD69sOefZlB16ayRJPsntZIE8JiNvjO06gvZUBhbwdrSPATPrZLIoVSJwaZtG/dJzGLWQ4Qd8D3kJ7pv4AQaSgnGBSkBGSqxx130f1uQvsS+pHMNDLEZ7qVwWA2/qeRSdXLQtO1g37sre/8nNwabHDSdC14Q+tROOpY68waPUD5ecFvQO3XLXOyLnyRxfxAGHtmLEelmYr08XiLoW+tPO1m+B63 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR0701MB3826;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR0701MB3826; X-Forefront-PRVS: 0457F11EAF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(6009001)(7916004)(376002)(346002)(53754006)(189002)(51914003)(377424004)(199003)(24454002)(53936002)(4001150100001)(6496005)(316002)(7736002)(68736007)(101416001)(6486002)(8676002)(81166006)(305945005)(50986999)(54356999)(8936002)(81156014)(76176999)(33646002)(478600001)(54906003)(106356001)(6246003)(16586007)(50466002)(72206003)(58126008)(39060400002)(76506005)(105586002)(33716001)(189998001)(4326008)(6116002)(2906002)(23726003)(1076002)(3846002)(47776003)(66066001)(2950100002)(42882006)(6666003)(229853002)(83506001)(6916009)(97736004)(16526018)(9686003)(25786009)(5660300001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR0701MB3826;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR0701MB3826;23:NYT0rl6YdhWbu9Qy1ohxzSDvbbxURKPrxKqyCA5?= =?us-ascii?Q?ROeK2nS1Ey0DHCiwfuI1ZKt1XwrIOG66y3MB11VQVZFilCj31a2UQ0davEOd?= =?us-ascii?Q?fbv6DJiMekwszx6qTdZz++tz9gh7SGO7ddysQigSaVCX3oHqOyjZYD1tCGbc?= =?us-ascii?Q?srVOeRT1mHaZKGD8zEc38Gr5pjPQ+WlDpYcgtp1BU0VRKxSbXGTxdpSf2Tl9?= =?us-ascii?Q?2l4teRAa1NLOhqLtEsWWbY+LqnRk7b52WfdtC72PmDseUzBgMFz12rsZAWiD?= =?us-ascii?Q?8ZYak+HPP8rH5DhkTSwpv8gnENdd1eHLLxoKVl/RJYKX+TMiNzX2ztg+8Dbu?= =?us-ascii?Q?9Vj/zboDXalZaUjd7B7SGKsfbu97gvv+7xaQp64NNFaNr0G3RrtC+lBjftTU?= =?us-ascii?Q?G50GpFe80hzVMhrxFlp60cqq2h5LMko0Esok8QVspwRyci/cjojmNEfB/Juq?= =?us-ascii?Q?sQ1CoxAJkVhacxfGx2MQRAYUOxALomzzdRqDIrZfCV5q7BW/WqPvZg770mRn?= =?us-ascii?Q?v13iRe7CGYNCkzL6/Qbo4FDnx3HvdlRhFGmf4U+hQnFhTlAIc6qhgLnPemc5?= =?us-ascii?Q?/cbGCWHpvXjdmuyJRkKH9Rc6gZPRDACTnK7l2Z7eROLOuEbejntFPPLZwCGO?= =?us-ascii?Q?2UnifzJl8n8flQAVURKvz/vdUbDz/QLHJQMcTbKWA0vOdandc6Bu3f7RCzlE?= =?us-ascii?Q?bV4LHMD18wvP4nAR6is7xP2AsqsIEvy2cYweKKj8RWOLra64acmerk+18dWn?= =?us-ascii?Q?t+6kUdZtARjgwtFKGVdnNt56/Qf/z24NU4Fd45YJ7ux5pU9WF/NCbK5HKxxE?= =?us-ascii?Q?UEgg3GtWpJYoHRxp9c2DJcjEMQ4et9i0CgdBfe6Pj/WiyONIJnPfIavIxC3f?= =?us-ascii?Q?dHpsL+2Rm+4U/V4fOTUJJG3cSDm5HoSXrZviKNg4CCrg5rxMxtl0WZWuCuvF?= =?us-ascii?Q?LvJ/xQEX7kImNPDOTSbxIKUw9Cvr6c5n7CiP+HHDHsNjdc7SClFgfcB/POaH?= =?us-ascii?Q?It0/vvVO2MaFGKznNy6reSMH4Rlcmp19RQkfL9DIaW7kTgKPIUI3KyZujiEq?= =?us-ascii?Q?8r8nGEMuFZjOBJaZIGYzVlyvHa77zZuYYGcSqo35Cdx6Q0DBM5A3vbOHH7YK?= =?us-ascii?Q?Q/0PE2njooqeSE2H3/nUbKoi93i7y8IiQ3WvloFmRfiRIbx0qlfwUQDmFIsp?= =?us-ascii?Q?f0bn90WX5zsC3AbzUcfBvxz+qV0G8lHvxREcReDkrSfFdWEtBqHWdJucUfGA?= =?us-ascii?Q?oPnec4bL3WZ3LSEFehDmJDfG9hOaKXMqfCnMQBPY+9vhbztiMsrtO4QUz0Qc?= =?us-ascii?Q?YfwouoKpocY6n6GgxXCwMr3/bfiEEgoEbTEiE56lZzBBSTvolTfD35OnWL6j?= =?us-ascii?Q?QncvVXC6/72U0hUOuefXpSI276pU=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR0701MB3826;6:MtVjT8epl84Vfvc1Z9urnHh+ogiSrNexvGSpsRUWRnp2NWNDRoM72M3WSmuz+wgqzWKWkA8ClelfbCRsP1KxPXD6/q4+nabN9u2AvLrEzz08yrXN9RZQA42q2mqUOw5eV5yOzphvXYd+aNFX8gm3cxUCV0W7k6Ge4fVSNhpPMuRZ9uhncfRcqQCQJXB9JtD/piYJ08HuuHsO+PFGEt9xOUrc3ZLTloQbouIZYnfiRr7syOm3vci10GrOKwFA6kVThMqRsYWtQEp2VYvmObML6f+nAZVMxB6s22+EoejkzdNsH0nS9P6OTaKQ+x8TNCu/zIJaR0LGOMi5/BaQKda/HA==;5:T2ixRDOuzg0t5waOwBfMVJ0T1LjSK+z5Xu/8FYVyNrE8vwRuR0lsItABHGNXoy7PD/UK28C+vJ4YV2jm93fvTC8TufMnMcdtRBklmjdEj1XjXpZyRLH65ZZcHFDWo2fyl6Qz4GX9uYva3Ojl15zgdQ==;24:eFj420WqsnKyviaJVBso2EF6P6O7tgprdAR9zoqQXTPyFr0aGnrWpSqICnbRQLRIJJR9PEP9OoXDKfZuKpYLCklQEfAPEjpYddfnJVwkY7o=;7:SGSu+/xCyfcO2bOhuh5Flnr8n0VHVNioBKtpZEodPk9XjFr1Ln51utmujnQ/ZGD+7f32LXO6lx3UBc8qS7Wk4ddEGe70VinRsQP19HjPyirKzQBbHL7DmxiEskZTv8da53sAl6leLj7Yt5e71JrTHT+wac/cq0euMEuGFFlniVV9/xMrpCWLiay4141fBniG3oFzfm5P607mHtqzlCrNFVZEgCUxPXUivNxxfTEXdek= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2017 19:44:12.3686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3826 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eric, On Wed, Oct 11, 2017 at 11:48:37AM -0700, Eric Dumazet wrote: > On Wed, 2017-10-11 at 11:41 -0700, Eric Dumazet wrote: > > On Wed, 2017-10-11 at 21:35 +0300, Yury Norov wrote: > > > Hi all, > > > > > > It seems like next-20171009 with ilp32 patches crashes on LTP sendto01 test > > > in sys_sendto() path, like this: > > > > Thanks for the report. > > Probably caused by one of my recent patches, so I am taking a look. > > Yes, this was silly. > > Please test this fix : > > diff --git a/include/net/tcp.h b/include/net/tcp.h > index 5a95e5886b55e03e4a8bfeac3506c657a4f97dde..15163454174babdcb465904f725b919268dd1bc7 100644 > --- a/include/net/tcp.h > +++ b/include/net/tcp.h > @@ -1712,6 +1712,7 @@ static inline void tcp_insert_write_queue_before(struct sk_buff *new, > > static inline void tcp_unlink_write_queue(struct sk_buff *skb, struct sock *sk) > { > + tcp_skb_tsorted_anchor_cleanup(skb); > __skb_unlink(skb, &sk->sk_write_queue); > } The fix works for me, thanks. Tested-by: Yury Norov