From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752954AbdJLBFr (ORCPT ); Wed, 11 Oct 2017 21:05:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:54322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752807AbdJLBFp (ORCPT ); Wed, 11 Oct 2017 21:05:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06271218CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 11 Oct 2017 21:05:42 -0400 From: Steven Rostedt To: Jeremy Linton Cc: LKML , Ingo Molnar , Boris Ostrovsky , Juergen Gross , "Kirill A. Shutemov" Subject: Re: [PATCH] tracing/xen: Hide events that are not used when X86_PAE is not defined Message-ID: <20171011210542.6ac512e7@gandalf.local.home> In-Reply-To: References: <20171010191256.3d6d72cb@gandalf.local.home> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Oct 2017 19:39:20 -0500 Jeremy Linton wrote: > On 10/10/2017 06:12 PM, Steven Rostedt wrote: > > From: Steven Rostedt (VMware) > > > > TRACE_EVENTS() take up memory. If they are defined but not used, then > > they simply waste space. If their use case is behind a define, then the > > trace events should be as well. > > > > The trace events xen_mmu_set_pte_atomic, xen_mmu_pte_clear, and > > xen_mmu_pmd_clear are not used when CONFIG_X86_PAE is not defined. > > The only place i see them being used is mmu_pv.c, where they are wrapped > in the stated #define. > > Looks good. > > Reviewed-by: Jeremy Linton > Thanks Jeremy, -- Steve