From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbdJKVmU (ORCPT ); Wed, 11 Oct 2017 17:42:20 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:41250 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750718AbdJKVmQ (ORCPT ); Wed, 11 Oct 2017 17:42:16 -0400 Date: Wed, 11 Oct 2017 22:41:31 +0100 From: Russell King - ARM Linux To: Florian Fainelli Cc: Abbott Liu , aryabinin@virtuozzo.com, afzal.mohd.ma@gmail.com, labbott@redhat.com, kirill.shutemov@linux.intel.com, mhocko@suse.com, cdall@linaro.org, marc.zyngier@arm.com, catalin.marinas@arm.com, akpm@linux-foundation.org, mawilcox@microsoft.com, tglx@linutronix.de, thgarnie@google.com, keescook@chromium.org, arnd@arndb.de, vladimir.murzin@arm.com, tixy@linaro.org, ard.biesheuvel@linaro.org, robin.murphy@arm.com, mingo@kernel.org, grygorii.strashko@linaro.org, opendmb@gmail.com, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, zengweilin@huawei.com, linux-mm@kvack.org, dylix.dailei@huawei.com, glider@google.com, dvyukov@google.com, jiazhenghua@huawei.com, linux-arm-kernel@lists.infradead.org, heshaoliang@huawei.com Subject: Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory Message-ID: <20171011214131.GV20805@n2100.armlinux.org.uk> References: <20171011082227.20546-1-liuwenliang@huawei.com> <20171011082227.20546-2-liuwenliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2017 at 12:39:39PM -0700, Florian Fainelli wrote: > On 10/11/2017 01:22 AM, Abbott Liu wrote: > > diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S > > index 8733012..c17f4a2 100644 > > --- a/arch/arm/kernel/head-common.S > > +++ b/arch/arm/kernel/head-common.S > > @@ -101,7 +101,11 @@ __mmap_switched: > > str r2, [r6] @ Save atags pointer > > cmp r7, #0 > > strne r0, [r7] @ Save control register values > > +#ifdef CONFIG_KASAN > > + b kasan_early_init > > +#else > > b start_kernel > > +#endif > > Please don't make this "exclusive" just conditionally call > kasan_early_init(), remove the call to start_kernel from > kasan_early_init and keep the call to start_kernel here. iow: #ifdef CONFIG_KASAN bl kasan_early_init #endif b start_kernel This has the advantage that we don't leave any stack frame from kasan_early_init() on the init task stack. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up