From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753174AbdJLRRC (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Oct 2017 13:17:02 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:53274 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752451AbdJLRRA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Oct 2017 13:17:00 -0400
Date: Thu, 12 Oct 2017 10:16:59 -0700 (PDT)
Message-Id: <20171012.101659.654720543467651527.davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: andreas.radke@mailbox.org, shuahkh@osg.samsung.com,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        linux@roeck-us.net, patches@kernelci.org,
        ben.hutchings@codethink.co.uk, stable@vger.kernel.org
Subject: Re: [PATCH 4.9 000/105] 4.9.55-stable review
From: David Miller <davem@davemloft.net>
In-Reply-To: <CADvbK_eDqUG5+eKpBreVtkDR1nNik327aNsz-rbf4jE7YmjAig@mail.gmail.com>
References: <CADvbK_dTji3wdKM_31DGMvUNYiArUv--PkZBO8Fxnatp=fxJ-w@mail.gmail.com>
        <20171012171826.122420ea@workstation64.home>
        <CADvbK_eDqUG5+eKpBreVtkDR1nNik327aNsz-rbf4jE7YmjAig@mail.gmail.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 12 Oct 2017 10:17:00 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Xin Long <lucien.xin@gmail.com>
Date: Thu, 12 Oct 2017 23:25:10 +0800

> pls try revert:
> commit 02f7e4101092b88e57c73171174976c8a72a3eba
> Author: Eric Dumazet <edumazet@google.com>
> Date:   Mon Oct 2 12:20:51 2017 -0700
> 
>     socket, bpf: fix possible use after free
> 
> which caused a obvious issue in __sk_attach_prog():
>         atomic_set(&fp->refcnt, 0);  <----
> 
>         if (!sk_filter_charge(sk, fp)) {
>                 kfree(fp);
>                 return -ENOMEM;
>         }

Yeah this is the bad patch, my backport was buggy.

Greg, please revert.