From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753040AbdJLIQj (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Oct 2017 04:16:39 -0400
Received: from mail-wm0-f45.google.com ([74.125.82.45]:43816 "EHLO
        mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750774AbdJLIQi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Oct 2017 04:16:38 -0400
X-Google-Smtp-Source: AOwi7QDa1XD8VJAJuG71de+fvwizVH0rtIVoG8WHCcsgaN5A+qeCGGmR/iGDwSMPzTANdyASTyNSBg==
Date: Thu, 12 Oct 2017 10:16:34 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>, Jonathan McDowell <noodles@earth.li>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v9 2/5] x86/cpuid: Add generic table for cpuid
 dependencies
Message-ID: <20171012081634.5xu2vtmmt3hbqohp@gmail.com>
References: <20171007000328.12843-1-andi@firstfloor.org>
 <20171007000328.12843-3-andi@firstfloor.org>
 <20171012080733.4y5wlghjr524cgr3@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171012080733.4y5wlghjr524cgr3@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Ingo Molnar <mingo@kernel.org> wrote:

> > +	bool changed;
> > +	__u32 disable[NCAPINTS + NBUGINTS];
> > +	unsigned long *disable_mask = (unsigned long *)disable;
> > +	const struct cpuid_dep *d;
> 
> The constant forced types are really ugly and permeate the whole code. Please 
> introduce some suitably named helpers in the x86 bitops file that work on local 
> variables:
> 
> 	var &= ~(1<<bit);
> 	var |= 1<<bit;

So instead of adding helpers the 1<< ops can be written out explicitly - they are 
easy to read after all. Can also be:

	var &= ~BIT(bit);
	var |= BIT(bit);

Thanks,

	Ingo