From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756834AbdJLMlL (ORCPT ); Thu, 12 Oct 2017 08:41:11 -0400 Received: from outbound-smtp10.blacknight.com ([46.22.139.15]:32951 "EHLO outbound-smtp10.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755917AbdJLMlJ (ORCPT ); Thu, 12 Oct 2017 08:41:09 -0400 Date: Thu, 12 Oct 2017 13:41:07 +0100 From: Mel Gorman To: Jan Kara Cc: Linux-MM , Linux-FSDevel , LKML , Andi Kleen , Dave Hansen , Dave Chinner Subject: Re: [PATCH 2/8] mm, truncate: Do not check mapping for every page being truncated Message-ID: <20171012124107.fk63gk656jhzgodh@techsingularity.net> References: <20171012093103.13412-1-mgorman@techsingularity.net> <20171012093103.13412-3-mgorman@techsingularity.net> <20171012121527.GA29293@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20171012121527.GA29293@quack2.suse.cz> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2017 at 02:15:27PM +0200, Jan Kara wrote: > > diff --git a/mm/workingset.c b/mm/workingset.c > > index 7119cd745ace..a80d52387734 100644 > > --- a/mm/workingset.c > > +++ b/mm/workingset.c > > @@ -341,12 +341,6 @@ static struct list_lru shadow_nodes; > > > > void workingset_update_node(struct radix_tree_node *node, void *private) > > { > > - struct address_space *mapping = private; > > - > > - /* Only regular page cache has shadow entries */ > > - if (dax_mapping(mapping) || shmem_mapping(mapping)) > > - return; > > - > > Hum, we don't need to pass 'mapping' from call sites then? Either pass NULL > or just remove the argument completely since nobody needs it anymore... > Otherwise the patch looks good. > You're right. Initially, I was preserving the signature as it's defined by radix_tree_update_node_t but the only user is workingset_update_node so it can be changed. -- Mel Gorman SUSE Labs