mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Mario.Limonciello@dell.com
Cc: gnomes@lxorguk.ukuu.org.uk, dvhart@infradead.org,
	andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, luto@kernel.org,
	quasisec@google.com, rjw@rjwysocki.net, mjg59@google.com,
	hch@lst.de, greg@kroah.com
Subject: Re: [PATCH v7 10/15] platform/x86: dell-smbios: add filtering capability for requests
Date: Thu, 12 Oct 2017 16:33:35 +0200	[thread overview]
Message-ID: <20171012143335.bbw3cxojzp66nqi2@pali> (raw)
In-Reply-To: <1200feb837864baa8a3be9740413f2e9@ausx13mpc120.AMER.DELL.COM>

On Thursday 12 October 2017 13:23:08 Mario.Limonciello@dell.com wrote:
> The existing dcdbas calling interface tooling (libsmbios) expects to be able 
> to access all calls and all tokens.  *The kernel doesn't filter any of it.*

It does not mean that API/ABI was designed correctly or incorrectly.
Existing old API/ABI is there and we are not going to change it...

> I understand the ask to filter some calls and that's why patch 10/15 exists,
> but please let me remind you this patch series is intended to /replace and
> deprecate/ dcdbas userspace access.

Now when there is a proposal for a new API/ABI, it should be designed
correctly without need to redesign it again in future and address all
problems which are found during review.

-- 
Pali Rohár
pali.rohar@gmail.com

  reply	other threads:[~2017-10-12 14:33 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11 16:27 [PATCH v7 00/15] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 01/15] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 02/15] platform/x86: dell-wmi: increase severity of some failures Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 03/15] platform/x86: dell-wmi: clean up wmi descriptor check Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 04/15] platform/x86: dell-wmi: allow 32k return size in the descriptor Mario Limonciello
2017-10-11 16:31   ` Pali Rohár
2017-10-11 16:37     ` Mario.Limonciello
2017-10-11 16:27 ` [PATCH v7 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 06/15] platform/x86: wmi: Don't allow drivers to get each other's GUIDs Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 07/15] platform/x86: dell-smbios: only run if proper oem string is detected Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 09/15] platform/x86: dell-smbios: Introduce dispatcher for SMM calls Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 10/15] platform/x86: dell-smbios: add filtering capability for requests Mario Limonciello
2017-10-12 10:09   ` Alan Cox
2017-10-12 13:23     ` Mario.Limonciello
2017-10-12 14:33       ` Pali Rohár [this message]
2017-10-12 14:43         ` Mario.Limonciello
2017-10-13 14:18       ` Alan Cox
2017-10-13  0:46     ` Darren Hart
2017-10-13  9:43       ` Greg KH
2017-10-13 10:40         ` Pali Rohár
2017-10-13 15:03         ` Mario.Limonciello
2017-10-13 15:19           ` Alan Cox
2017-10-13 15:44             ` Mario.Limonciello
2017-10-13 19:46               ` Alan Cox
2017-10-13 22:16                 ` Darren Hart
2017-10-13 15:56           ` Greg KH
2017-10-13 17:47             ` Mario.Limonciello
2017-10-13 22:28             ` Darren Hart
2017-10-13 16:37         ` Darren Hart
2017-10-11 16:27 ` [PATCH v7 11/15] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 12/15] platform/x86: dell-smbios-smm: test for WSMT Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 13/15] platform/x86: wmi: Add sysfs attribute for required_buffer_size Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 14/15] platform/x86: wmi: create userspace interface for drivers Mario Limonciello
2017-10-11 16:27 ` [PATCH v7 15/15] platform/x86: dell-smbios-wmi: introduce userspace interface Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012143335.bbw3cxojzp66nqi2@pali \
    --to=pali.rohar@gmail.com \
    --cc=Mario.Limonciello@dell.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mjg59@google.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=quasisec@google.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®