From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899AbdJLSHk (ORCPT ); Thu, 12 Oct 2017 14:07:40 -0400 Received: from mail-by2nam03on0060.outbound.protection.outlook.com ([104.47.42.60]:26544 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750729AbdJLSHi (ORCPT ); Thu, 12 Oct 2017 14:07:38 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Felix.Manlunas@cavium.com; Date: Thu, 12 Oct 2017 11:07:27 -0700 From: Felix Manlunas To: Arnd Bergmann Cc: Derek Chickles , Satanand Burla , Felix Manlunas , Raghu Vatsavayi , "David S. Miller" , Intiyaz Basha , Rick Farrington , VSR Burru , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net] liquidio: fix timespec64_to_ns typo Message-ID: <20171012180727.GA2071@felix-thinkpad.cavium.com> References: <20171012094841.3178599-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012094841.3178599-1-arnd@arndb.de> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: MWHPR14CA0040.namprd14.prod.outlook.com (10.171.142.154) To MWHPR07MB3183.namprd07.prod.outlook.com (10.172.96.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 503108f6-8477-45a2-7817-08d5119c1e99 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:MWHPR07MB3183; X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3183;3:5L11HAA3xPRAYYFuDHcq9BAWeIdoTuBPrYL1aB5AnHfT87yAAztPAZBQhbW+i4H1Mb8E0FYxgj59nQuEwbFrhWWLamm66nmCi4Xab5xaQpG8MYWrxFCxwOFdeMvmfnuYQEM99cu241z8DXFqZs+HtNG1S0N1XRQ2BlOwHHSqjbL8LlQ+uSgnVPv7IjPmxj4BOJTY6NDEa+zLq/qQi3ew078sqv19PvM8YrfxT9VegsRQxwE/ewM3tLQpUIWa8E8a;25:F+wwe9mtQ1nEOA0UHra67khiRVJhtcpx2cfx07ckB7FhSu7oH9IVcMt4v8pNoR/eVOF2prGGumv6huc7Sr9tSRjbLUEV3g+u5/8oqNAvhlS+Ro1Ze+ujxcarogJbqFBM8fbSzXkq6Fi/Z7xI9EumGBe94IlCuBcUvXGR3KItRU2lvnLI9RDOk8KU31KG3KAz0grWx/WOLJoijKQQEv07UaIJaWoJ8QL0iAs4bUsZ3jflimPf5xvs8eia+S9ZIlfZs8xgTfCh10L0LTILxdASnE4mZb5SUUqBIk90Nf3ONYoSbx3Nzo3PMgcjz4cZ/DUuObn7DzpuLqiWhf3GmqeXRg==;31:6lGng1wfIMA8Q/prNjWWykbCkN8waJdEUt7KY6x0jl/YSCEN/aqBzUg0cYGMSIFpwyNbpJFFY+ztS3jFHZuccoBQhDL1FMLq7uZDVCsT1KbnVLRa8whVFHNDDXUZ87NWqr1QMjt4LFrMVO8lvM/sKwCxEekJp9soize70HaY3RC/dftWZ4x00KKokxR5qRkHp/IAjTtXvDmGUVOgA/eIgJVEq4PPr/5UyVbVbT5CDD8= X-MS-TrafficTypeDiagnostic: MWHPR07MB3183: X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3183;20:P24FbkzBlB/2cxFsgEP6kODTWLmirGS/P7WpCgGlRYxd9CyhJS6oJKLq+txg2g8Z5Sv13mRvP1GMJ7FpD7fRjsnG4xW5slqRfMAedMjvEbKHNX+ubRF576V5RIQaVtKyw4BGnA6AvZtONtwmMJ/DrJa374uWCGMvY24wiqP4M3dX9gjHgP+kEfX90CiKDF4diWK3BVMq4TIl/qQLfE63kOFd341YrZYg1IWxWp7gkBhMuzIPFJr1Gc8eR/HFXSedqwXXGavXi18HB5pHlq22Cf/Z8dQYT9ASslSfkoat/cbvB9NA5TxZnUp+Nyd1EWM8BeYvkf5fhXAzyS7LJ37DmWIK9jmMWjOSkH0WAzjjUumofv7JssjD1U+WvOPuuy7Y3B0xUxQy9nxRU6MRWIMH5EwxqguKxYpeOA29HWOcJK5ywF5HTC/oOoXWfXkRM+vJOC+Hft2V8kpKwoFlAUPUMpGiAKqH/wEB4VO45OwyhJkhCZKnfr0f3dYbEugQb7if;4:DRFIrnpXG8SVfg5L8WLoEzozxw1avhbH/UsYreLexlfxU9b6g2K0yzZAf0y5wbzaAFxpwWlddKJ1L8QGsnuR56ItslVqiDQptS/TW1VaFPN8GVgYdCEXrx9rQIbG/KrVAUiOAqpCA9Jy0OlmkyN7fjTTOQDNmHtaaq6z8gnZE6DZ2+lDPNLTJRAVWg8Fg7aeiRWE1KuAwrqUTHBtZkzJpOyg0gG8Xx/5iwUXDX6NZRTrNhHGUYuvepgnqXHNnHLd X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3183;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3183; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(6009001)(376002)(346002)(199003)(24454002)(189002)(6916009)(53936002)(105586002)(101416001)(2906002)(6116002)(76506005)(83506001)(106356001)(6666003)(97736004)(23726003)(3846002)(316002)(7736002)(6486002)(1076002)(25786009)(189998001)(305945005)(33656002)(229853002)(6496005)(6246003)(2950100002)(50466002)(4326008)(81156014)(8936002)(81166006)(47776003)(86362001)(8676002)(16586007)(54906003)(478600001)(66066001)(76176999)(5660300001)(58126008)(68736007)(72206003)(50986999)(16526018)(54356999)(18370500001)(15760500002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3183;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR07MB3183;23:gQrqckkY9qu80roNVe5VTGN9yn33+SYLHudw/wkSd?= =?us-ascii?Q?2WUJAjEufWxf2dVK8G2xGrgxCkLABkq7B8IA6MVJAwOs2mqGLvD7ptyQwKjC?= =?us-ascii?Q?cU2fr+DZPt+7zQGrYIUEIxKBqzQOoW2AbREk6PB8utDacvCztT3lF2TxO+HW?= =?us-ascii?Q?MZKEn22nhbkxNVcOorWCZh2VDE7HjdASDK2yGB2WFRTzbrXNWkmQDsLzhjrZ?= =?us-ascii?Q?Ow6B5njJdAvHqr71XRsX8m2plns4VMYlUy1V4tINfVTfeBUo4fwo82EpfNMN?= =?us-ascii?Q?LLVVcToZuRrh3VnjJupWW7XX9aiFlvZzu/KdT0gZydt68dMkfHUibeHyzbiE?= =?us-ascii?Q?C311+LUmHR+Olw7s3MnVrOcRdUFzfYE1c2P31FfX0gR8qVnY2JpMEA1RWgMv?= =?us-ascii?Q?r8dPufQ5NrXQP582IA9L37K2AWqLB2dicTNPaz+wGfvZvlkRRiNlBnypytGL?= =?us-ascii?Q?YKtO28xQFMLfYNYqIOzzNuoqzuejxqbk+lotTkC/7aFUR4hDCL0lU8owTz85?= =?us-ascii?Q?2MIQjeufcqTsMmA5C/PCSXz3ZPLBYqyCCibWZZjEyWHosCPlTdKTYVq1+iZO?= =?us-ascii?Q?ZD7xRNP1J1dqfETmCKNz2oLYfwLYsvowtdzqbxNN/XVa2QVl+tO0j4ZmVMk4?= =?us-ascii?Q?Wn7I8cFvtSW+7OolSEjJwZNVyG6H6XqlfcbMHEd+ZMav4UZAuNL8O0jC3BvW?= =?us-ascii?Q?2NcVqLCLw3LXwHkgzrSRc6qWdtc52ksGlhA/hRz5AWh/LSji2Ce+tygLaZRQ?= =?us-ascii?Q?/GRpEX63tkBf0O/ei7++wux41lmJ3uObjhAiY7ztaA25DJ7Nqt4ZYO2+Tb+L?= =?us-ascii?Q?2cbV/HiDx9RfM3wOaNCdTe8rIihb9lR3BLTeZwikzFIwPrunKt6r3MZZylA/?= =?us-ascii?Q?Gv/b2Vphrp36T+hgFQpXP+1yqkwNihe6XDm5123iOH67DUCT7AeBY178unE0?= =?us-ascii?Q?Vi/q5onuedBUBMVQEBMuxOzyL0G4OoA+0lOG1JT45gf8QWZ4cDHZXf8G0h+u?= =?us-ascii?Q?BC+QaaLF6uvWRMuuqssSCsODPnmzyTMR26FY8wuOMF6xgtEs8bmVv9fHBHqF?= =?us-ascii?Q?glPp6InVizgvTliBds53C58+vNyJwpKFxixCjTpxiBQb/x5UKSdRlVBoy9Zf?= =?us-ascii?Q?eT9/CroPwmMe+33jUVWejf2m2IU6HatS1z3QyShn2l8p40vn7srNlU6sbPMG?= =?us-ascii?Q?XqFsrM0lIqBWB3FFH5KZTLp886FPpu/IiANZumJaAZP3fhthfrzKlUrJc1oR?= =?us-ascii?Q?kE4ssvgPyeGSzAgb9U=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3183;6:jQV8ZQNSDS7LiG99gvFUHiGBHx9cnR6Y1oVAbN3M6AgYhHuQAMYEEoungBkIlKFgxSJDIuoJgnfYEitgp9xacNWpWSAGYzhQEpv4shd+fE7aPU78jeFFik78toDmujC80Z5P5MBXKv42YWa4Srg/P7e6pr4KUwvmoFE2WKU1W/CSrSeQ6IHSkSW+oo2VwpAcAkovW7InsStjmSXSrSXxnwQrU4tZfCXS9jWCoHSaMBeejcWB09eXFrZo1CeT48k1MMUumdxKLdSdMhfbMtNxyeh+9NziB4SE1xKIgs/thOJQSmZ7DxLuQz6qvk5SmrvDLd/k9mfZNXoRyyYW4RO2nA==;5:Zlp8n0oMP7Gs8VMQQSPIfpbyAtGwlHRKP8GP7I5E0mHBZYfnpu4dtMCPf2ThB3SdDAMojVS4DAug2mtxRSXIbuFXz/5szPj6TfLfdgei91r7UsxFZ/LC2T9rpaOQ5tlLF5mwYHh1fWvSGRyO4R8+aeh4tEENT8KmVDuNL4Rojd8=;24:N9bL9PoHj3Js4hxbSmWTW8CyKo4/0GevvKAKPfL9QvYvy+MAYKgSPeMvPiGr8FxC1mPvBoS+F18lNvortNt1vj4sZqeX7bMVfnzr8cGA1SU=;7:QvmmSC27SIeR0dorZaOMFCHaKuoJW/VqgUKqx6E0gc4yACQCKKhp+VO3Sgfsn96cCTmuNhwQdvpY+AEasg0BpCiwPTdxoFQLGzSJfzv6gTrzaBeaFQ6jvdWlymhC6DJ37ROECv8lrbU6hSt/ZYwk8HMfU0Y5Qz/gwkeHIUgHbN6lrqNaqYsHxPWtWEqVZhkrgxA9GjF+hTgYMnm13DChWFrlOWdFIplre4MoVzt54vo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 18:07:36.7644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3183 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2017 at 11:48:31AM +0200, Arnd Bergmann wrote: > While experimenting with changes to the timekeeping code, I > ran into a build error in the liquidio driver: > > drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'liquidio_ptp_settime': > drivers/net/ethernet/cavium/liquidio/lio_main.c:1850:22: error: passing argument 1 of 'timespec_to_ns' from incompatible pointer type [-Werror=incompatible-pointer-types] > > The driver had a type mismatch since it was first merged, but > this never caused problems because it is only built on 64-bit > architectures that define timespec and timespec64 to the same > type. > > If we ever want to compile-test the driver on 32-bit or change > the way that 64-bit timespec64 is defined, we need to fix it, > so let's just do it now. > > Fixes: f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters") > Signed-off-by: Arnd Bergmann > --- > drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c > index 963803bc6633..eafae3eb4fed 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c > @@ -1847,7 +1847,7 @@ static int liquidio_ptp_settime(struct ptp_clock_info *ptp, > struct lio *lio = container_of(ptp, struct lio, ptp_info); > struct octeon_device *oct = (struct octeon_device *)lio->oct_dev; > > - ns = timespec_to_ns(ts); > + ns = timespec64_to_ns(ts); > > spin_lock_irqsave(&lio->ptp_lock, flags); > lio_pci_writeq(oct, ns, CN6XXX_MIO_PTP_CLOCK_HI); > -- > 2.9.0 > Thanks. Acked-by: Felix Manlunas