From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756214AbdJLWcm (ORCPT ); Thu, 12 Oct 2017 18:32:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:43780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965AbdJLWcl (ORCPT ); Thu, 12 Oct 2017 18:32:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AC11204EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 12 Oct 2017 18:32:39 -0400 From: Steven Rostedt To: "Paul E. McKenney" Cc: LKML , Andrew Morton Subject: Re: [PATCH] tracing, rcu: Remove no longer used trace event rcu_prep_idle Message-ID: <20171012183239.2dc52914@gandalf.local.home> In-Reply-To: <20171012222645.GO3521@linux.vnet.ibm.com> References: <20171012181257.27c7e3b2@gandalf.local.home> <20171012222645.GO3521@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Oct 2017 15:26:45 -0700 "Paul E. McKenney" wrote: > On Thu, Oct 12, 2017 at 06:12:57PM -0400, Steven Rostedt wrote: > > From: Steven Rostedt (VMware) > > > > Commit c0f4dfd4f90 ("rcu: Make RCU_FAST_NO_HZ take advantage of > > numbered callbacks") removed the only instances of trace_rcu_prep_idle, > > but did not remove the TRACE_EVENT() that creates it. As defined trace > > events take up memory within the kernel even when they are not used, > > this is a waste of space. Remove the obsolete event. > > > > Signed-off-by: Steven Rostedt (VMware) > > Good catch, queued for review and testing, thank you! > > Slight change in the context of the final hunk of the patch for -rcu, > updated version shown below. I now have a utility that complains when tracepoints are not used. But I'm working on getting this to work at build time and not run time. In the mean time, I might as well do some clean up ;-) -- Steve