From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757101AbdJMBfG (ORCPT ); Thu, 12 Oct 2017 21:35:06 -0400 Received: from smtprelay0092.hostedemail.com ([216.40.44.92]:41705 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753313AbdJMBfF (ORCPT ); Thu, 12 Oct 2017 21:35:05 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2691:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3873:4250:5007:6119:6120:6261:7514:7576:7875:7901:7903:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12663:12740:12760:12895:13069:13161:13229:13311:13357:13439:14096:14097:14181:14659:14721:21080:21451:21627:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: cars48_494b955abea43 X-Filterd-Recvd-Size: 2192 Date: Thu, 12 Oct 2017 21:35:01 -0400 From: Steven Rostedt To: Alexei Starovoitov Cc: LKML , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH] tracing: bpf: Hide bpf trace events when they are not used Message-ID: <20171012213501.17fe6f8c@vmware.local.home> In-Reply-To: <20171013011450.w2uqygdfzwf7ud64@ast-mbp> References: <20171012184002.0661a867@gandalf.local.home> <20171013011450.w2uqygdfzwf7ud64@ast-mbp> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Oct 2017 18:14:52 -0700 Alexei Starovoitov wrote: > On Thu, Oct 12, 2017 at 06:40:02PM -0400, Steven Rostedt wrote: > > From: Steven Rostedt (VMware) > > > > All the trace events defined in include/trace/events/bpf.h are only > > used when CONFIG_BPF_SYSCALL is defined. But this file gets included by > > include/linux/bpf_trace.h which is included by the networking code with > > CREATE_TRACE_POINTS defined. > > > > If a trace event is created but not used it still has data structures > > and functions created for its use, even though nothing is using them. > > To not waste space, do not define the BPF trace events in bpf.h unless > > CONFIG_BPF_SYSCALL is defined. > > > > Signed-off-by: Steven Rostedt (VMware) > > Looks fine. > Acked-by: Alexei Starovoitov > > I'm assuming you want to take it through tracing tree along > with all other cleanups? Either way is fine. I have a few other ones. I believe Paul is taking the RCU patch. There's no dependency. I'll take it if it is easier for you. I just need the ack. -- Steve