From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756248AbdJLVnc (ORCPT ); Thu, 12 Oct 2017 17:43:32 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:49383 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755647AbdJLVn3 (ORCPT ); Thu, 12 Oct 2017 17:43:29 -0400 X-Google-Smtp-Source: AOwi7QAtzPcZuvNa04J2Uzvvqyfu1jqr+1Gqy+rl1dd1EFwvs5JTpeOY6rLKyUP4wygGzFjm9YY9dw== Date: Thu, 12 Oct 2017 14:43:27 -0700 From: Omar Sandoval To: Christos Gkekas Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: Clean up unused variables in free-space-tree.c Message-ID: <20171012214327.GA16154@vader.DHCP.thefacebook.com> References: <1507844442-26013-1-git-send-email-chris.gekas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507844442-26013-1-git-send-email-chris.gekas@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2017 at 10:40:42PM +0100, Christos Gkekas wrote: > Remove variables 'start' and 'end', which are set but never used. Oops. Reviewed-by: Omar Sandoval > Signed-off-by: Christos Gkekas > --- > fs/btrfs/free-space-tree.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/btrfs/free-space-tree.c b/fs/btrfs/free-space-tree.c > index 684f122..fe5e032 100644 > --- a/fs/btrfs/free-space-tree.c > +++ b/fs/btrfs/free-space-tree.c > @@ -1286,12 +1286,8 @@ static int __add_block_group_free_space(struct btrfs_trans_handle *trans, > struct btrfs_block_group_cache *block_group, > struct btrfs_path *path) > { > - u64 start, end; > int ret; > > - start = block_group->key.objectid; > - end = block_group->key.objectid + block_group->key.offset; > - > block_group->needs_free_space = 0; > > ret = add_new_free_space_info(trans, fs_info, block_group, path); > -- > 2.7.4 >