From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757152AbdJLWnc (ORCPT ); Thu, 12 Oct 2017 18:43:32 -0400 Received: from mail-by2nam03on0046.outbound.protection.outlook.com ([104.47.42.46]:7545 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756606AbdJLWn2 (ORCPT ); Thu, 12 Oct 2017 18:43:28 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Abhijit.Ayarekar@cavium.com; Date: Thu, 12 Oct 2017 15:43:22 -0700 From: Abhijit Ayarekar To: Alexei Starovoitov Cc: Abhijit Ayarekar , ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yhs@fb.com Subject: Re: [PATCH] Add -target to clang switches while cross compiling. Message-ID: <20171012224322.GA7007@abhijit-ayarekar.cavium.com> References: <1507841157-10487-1-git-send-email-abhijit.ayarekar@caviumnetworks.com> <20171012222302.3zlndmcm7ixywbs6@ast-mbp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012222302.3zlndmcm7ixywbs6@ast-mbp> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: MWHPR15CA0063.namprd15.prod.outlook.com (10.174.254.25) To BN6PR07MB3556.namprd07.prod.outlook.com (10.161.153.146) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c3ea4b99-69fa-4fba-7c0f-08d511c2a6a4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:BN6PR07MB3556; X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3556;3:RTRtfyVUcBSkimtRXCxMs2KlBob+/WdG6G1rnSr4FDRgoHT+sb/j3g5qwZ+X2DoTQBffnI0MRRgpjHY80zxWLETFsQF3aANMj6xav5l6Fsb9+UB6+s3fqlvlzIHF7U8nDbVIDe17X+a5pkCly+fta48+IP//7WmWxbLFivStuMa0C8XxAdEPn5Ao/mh35ftY8SUR+DcLkqXqRznZW9slOsvUCSgppwenXifv2k5y6k33Bk4zJpPz17HdsaqPhpYa;25:mFi5qsfc9HqYUV/HUusexhfpR2BgChdptvlZ6ghV3KYHR0fmFSEd7c0YRvBGFcr/czygA8P4L3W+TB5uCWq5GYvSOYL2QPrIHmYHfSRu4tQ922dNWM2kWndQdpOjfy5MGDLjkPzNMA9cIRH2oAUoyzwSdGxHzWfrNsrXj39ErhZmmilk4Xbx2vwHU7m4l3GdynLyRagWZKAZ8A1jcnGOgGbOZr8ndymxhXmfxFL7qcDtuTeazfkRTPHE6Z2S91Z3NQjkyGusuyPU2Wrm5JfqPAQiF/P9pH+41iPH45bajPkM4CpUEHS4xdG7emp2J0fvAfpCiM/rHXPQMCWKtRlipA==;31:xVzUUzdW2f2eCnT/CrU8SdV9xStAvWeE8FYzQl1yHBc1GdJ2RbDMeft16ztxsDCa6UFA3tzm6GMmIeUCXg3l/lpF+JxSluAwy4WpJUs2bewjG0pg5KZKKOYU2LUjfCE+BmZUTKYsc4dr5PpYZ96eO/4yjulUMDZslsEhuQn0OW4iz/C7jCPRw+FyzBs3klu8JB3kIPAjIdaUcit3UwHsjHg3gMhEGVFQ3r8dC3ftTTM= X-MS-TrafficTypeDiagnostic: BN6PR07MB3556: X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3556;20:AVYJMv440LZ+tQF8VcMzw1uT/7poh6+QKH5EXfVx5cDcBf9cE+21FGlOFPnQGki6+vPJzqs72Q9DLzhX5OffiSnINgQpHYwnTSDcQqa4PZwf3xPNianJbyy5M75kpD7ae9ZKbmwQFxHq+d7tgTtHjmaDH6z4DpyKGziJ+cWteq/xCzlcwmTTZwMywjatHanqI8ivEGa/HUVbl9yQBZAWac6C3JE+A87UldGT6Tf34cs+XzRggjAu6ytm/U1+3VNWHbLKQop4C/tgjb5nZA74yh7leef/rL5JqeQMlrp9OXkC+QkzhwWTZlRPzfGtdAELlohjNC4CFEQ85Y5BeNat+nc+6FdtQnhKlVOo5FmiWvEuw5OCjCmpVqv4LOJf0pg0KaGDBxI1zF4BGbNqAi5Sosg4ZtXcsvn4xijlfBV+PJkixIrALYnawnSsQuECKWurkjHRvsTqMWYJarHzE8LKd7vnC58F12u/D2OCzwM2NV6/M4m6LKoTQlSh+RgP1XXu;4:jx6S5w8Cx7mjqXrT/OddUenWASjRpNXlufwEJs91GgPpsxXePHbG8Xv+H7fS7Dcz0SjqxqpNotErKFr7Klwfp8c0aRLoq+DTw5FSfQjTnTnnmJm0BFJ2EEgF0ta/xlpFssKQw7+51/qKIl0ivxZpMcjLF5Tw1omsEeJpQNKilVML+/8p0yUASvk64Dm/BMBgkImYv8KNJNhPmesFrSUSUNHDTSlXpNu7GtxSnuO0vMhBfPhCF4WY9g/hxZ2UXPk/sf4+ArK2x7QyFuNU96S0+v9uYUaYM3wk+bOnezNvqHo= X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR07MB3556;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR07MB3556; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(346002)(376002)(199003)(24454002)(189002)(6496005)(76506005)(6486002)(4326008)(101416001)(50986999)(25786009)(6246003)(72206003)(39060400002)(68736007)(33656002)(478600001)(105586002)(54356999)(76176999)(106356001)(53936002)(23726003)(7736002)(1076002)(305945005)(5660300001)(83506001)(3846002)(8936002)(50466002)(16526018)(316002)(6666003)(189998001)(2950100002)(6916009)(6116002)(81166006)(81156014)(8676002)(97736004)(2906002)(86362001)(16586007)(58126008)(66066001)(47776003)(229853002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR07MB3556;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR07MB3556;23:9iuAR9MqKtx8r8cVy6Jxqo2x9Nd7U4AkJISeV6HHe?= =?us-ascii?Q?cdskvtS9vsP/28WgDLM33bpsCLZ5J6fYeYGhtyKaFg92vE1t3twDkEyiDwjL?= =?us-ascii?Q?n8iUeDuoeIjylYJYVRZPXSX5YCbPnLYhzCy1FZZcq2wuH6IdMj3DHUsf83Sk?= =?us-ascii?Q?hnW31fg+41hTYQAHBYAmA7ixaggX0UUJ/w8+IHZQrEPKln7JAc3meUyjI9m3?= =?us-ascii?Q?VcPxZmZFAqWT06WDlJlb79TThluNDQAaoR9C3E2plyGskYTiqFjPp8ubJC14?= =?us-ascii?Q?cUah8JnVc2A9260wd53w4CSlvPWjrO0/WwXvPhRdReAaAIRkl4mEBdAh5Bnw?= =?us-ascii?Q?K21p9engV2gZi47zmpQfNgky2+23H50x6fDqIxmGerxVGJn45Gws2bIrqUaK?= =?us-ascii?Q?qb0L1M37D4Km9RoHJb8MJXpEbIDFxh7QwfdyMXvcAhe7uF8m9ukbpunjlgzG?= =?us-ascii?Q?5kkmX9BnQFDgkrW0D79OJlbi/xGpnYRDPP3kkmcedUcy6wHYM0tyMoKhsp+v?= =?us-ascii?Q?FY3JoCxayY7bKtTyxwMpLisSVHn8W3LlAIK+NgdmiHnw7wvYuhV9e/+3dWh6?= =?us-ascii?Q?5Sx7qp9q343GOaQfHTOcW9WBcyME1TBc9AevNlGbaiNROzeKj5hcdnWeDelj?= =?us-ascii?Q?u5QmpBvyRRjhMKAEVk9aALfIrFiTGdpfNftvm/Ak7spxocYbqdYufAaj1wtl?= =?us-ascii?Q?Cd72CUqgpGsLkRRWNsY4X2sbVVqAS+6cnisVyMSlnbIbz6fLP5clwZmmqzSH?= =?us-ascii?Q?6o4UeDX6CIRj4D9N1midhqFrWvnMIE9AlrNhJnAnOR3ILI1JtyjN5kwbBWmh?= =?us-ascii?Q?G3Dqn54P3Be0MAJVfaoy4gv7ZUnm307QSqZ81ZdxGORHWUlkDeH6jb8S5Ap8?= =?us-ascii?Q?coNAzmBWinGHoA6oOSciQlSxoUUSBPW8DG0Mn887/XuctFhLXEC2yPA+po9V?= =?us-ascii?Q?rkXWQWRhNtw4UBdoVfjxFwR4VLZr/p56jtHf/DhPv0Rfrm6EFiLxRecvX7XB?= =?us-ascii?Q?U7ErheSU4R+844iHG4A2IxcVaGFb/nKWwXJhVdgt4/eQNtTxdpkQxavZIxL3?= =?us-ascii?Q?+vmj7FOZR0PChgxf2tWZx2Dj3zoKUROPf2Zi4rH8lYSBvh49NCKIYataFZU+?= =?us-ascii?Q?zqkXK/sA4fiO1klKYwvjq3KmcFcn9jHHvywXkYvMk8t4kOKNTx8OLrL4sVG6?= =?us-ascii?Q?Zc1AiWU+K7lv+z83BWOH7jK+0/gMKdrPGZvK8ePut0917D42CIMr7nsmQ=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3556;6:PSGRyz/ubaxoFUS7tadfi9AmLSJHcTZX2+2NTJlfNm0ezSWtPIOZKk9sPKSf1kMaEiUBtUQxtv5ETjtOIiKYeE69WiJjFUzRCB08J/+/QUy9bwKD2XM6uhxGfaRaX/OUKfRktHUanRvUbY0MKWtpnkx8iHsQKikyDVxA6A6GOHC0TR6nkFI0l9m9knnB80DXynVIrGfqxZAzAiiHcZMjEwBsdy/YzUsjDgnDTM1nUH6SlV1LiiaZ1+6tNG6r6Tj0IHvgvgcNSdCWGGNU26PrvCwNrMWbLwcpF+ihJJu6TYGtX1eH2RwM/4tC0EMzcI+F/T0Q+SgKL80k0vJ9nStvig==;5:DxC3Vqnr4tsl+QyeW3Yf7/nREz67T/VVCEfBW5H8G0Vifqe1C0/w5XpcwWo08QtPrQ3tdgQk+gvXupyEJSDhFNk/+5v3bXdDt61QaBM72lIZut3wZi7e6UchLWnRVe+U2bDozwxczlsf9+RfDgxhfg==;24:fqeXNZqJLS55mAs5olAf3qBqGz+JsAgT1emWX4aMVnpnbWUrMY3EicKDvQ+9LVQew1Q7oVkpZ5uuF5wkdeg896rzO1c+s0D5CLu7bjUZsG4=;7:J8gP4XDFnGqz0oaxZu7EnyP8NA23DOzX6lBUEWI9lfVT52OowMcMWJ8cEKYtG/GefwV4MuK9qAQaTweC2oTspdlLepeE9w/807LEK9vn9yICNe3reNm4xDjMEL5CemJ23oP7mnELXFjas/ycpmycnGddFtjn77mUueNSJLLGZALmgwz2vL8Hg7GWIZu0H5eI5x+D0uLTCpyS0kyozQeDXIyxdXmM8D37gVmi1gGL4Sg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 22:43:25.7418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3556 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2017 at 03:23:04PM -0700, Alexei Starovoitov wrote: > On Thu, Oct 12, 2017 at 01:45:57PM -0700, Abhijit Ayarekar wrote: > > Latest llvm update excludes assembly instructions. > > As a result __ASM_SYSREGS_H define is not required. > > -target switch includes appropriate target specific files. > > > > Tested on x86 and arm64 with llvm with git revision > > commit df6ca162269f9d756f8742bf4b658dcf690e3eb5 > > Author: Yonghong Song > > Date: Thu Sep 28 02:46:11 2017 +0000 > > > > bpf: add new insns for bswap_to_le and negation > > > > Signed-off-by: Abhijit Ayarekar > > --- > > samples/bpf/Makefile | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile > > index ebc2ad6..81f9fcd 100644 > > --- a/samples/bpf/Makefile > > +++ b/samples/bpf/Makefile > > @@ -180,6 +180,7 @@ CLANG ?= clang > > # Detect that we're cross compiling and use the cross compiler > > ifdef CROSS_COMPILE > > HOSTCC = $(CROSS_COMPILE)gcc > > +CLANG_ARCH_ARGS = -target $(ARCH) > > this is only need because you're crosscompiling, right? Yes > In native compilation it's unnecessary flag. > Only droping -D__ASM_SYSREG_H is enough, correct? > Yes. That is correct. > > endif > > > > # Trick to allow make to be run from this directory > > @@ -229,9 +230,9 @@ $(obj)/tracex5_kern.o: $(obj)/syscall_nrs.h > > $(obj)/%.o: $(src)/%.c > > $(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(EXTRA_CFLAGS) -I$(obj) \ > > -I$(srctree)/tools/testing/selftests/bpf/ \ > > - -D__KERNEL__ -D__ASM_SYSREG_H -Wno-unused-value -Wno-pointer-sign \ > > + -D__KERNEL__ -Wno-unused-value -Wno-pointer-sign \ > > -D__TARGET_ARCH_$(ARCH) -Wno-compare-distinct-pointer-types \ > > -Wno-gnu-variable-sized-type-not-at-end \ > > -Wno-address-of-packed-member -Wno-tautological-compare \ > > - -Wno-unknown-warning-option \ > > + -Wno-unknown-warning-option $(CLANG_ARCH_ARGS) \ > > -O2 -emit-llvm -c $< -o -| $(LLC) -march=bpf -filetype=obj -o $@ > > -- > > 2.7.4 > >