From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755985AbdJMHaY (ORCPT ); Fri, 13 Oct 2017 03:30:24 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:42612 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbdJMHaX (ORCPT ); Fri, 13 Oct 2017 03:30:23 -0400 Date: Fri, 13 Oct 2017 00:30:22 -0700 From: Christoph Hellwig To: Nicolas Pitre Cc: Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Brandt Subject: Re: [PATCH v6 1/4] cramfs: direct memory access support Message-ID: <20171013073022.GI9105@infradead.org> References: <20171012061613.28705-1-nicolas.pitre@linaro.org> <20171012061613.28705-2-nicolas.pitre@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012061613.28705-2-nicolas.pitre@linaro.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This looks much better, thanks. I'm not a big fan of the games with IS_ENABLED and letting the compiler optimize code away, but you're the maintainer.. Reviewed-by: Christoph Hellwig