From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756331AbdJMHo5 (ORCPT ); Fri, 13 Oct 2017 03:44:57 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:43703 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbdJMHoy (ORCPT ); Fri, 13 Oct 2017 03:44:54 -0400 X-Google-Smtp-Source: AOwi7QD9Bik2EBWt4EEX9F9+ZHBbhtYeREqMd96v9aXyXJZrCgn/Bc7U3OgcsZ5slQRxSQZ22WArpA== From: Stephen Boyd To: Rob Herring , Frank Rowand Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH] of: unittest: Remove redundant OF_DETACHED flag setting Date: Fri, 13 Oct 2017 00:44:51 -0700 Message-Id: <20171013074451.14176-1-stephen.boyd@linaro.org> X-Mailer: git-send-email 2.14.GIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_fdt_unflatten_tree() already sets the flag on the node to OF_DETACHED, because of_fdt_unflatten_tree() calls __unflatten_device_tree() with the detached bool set to true. Signed-off-by: Stephen Boyd --- drivers/of/unittest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 35bf9617ae59..8795478a4754 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -1112,7 +1112,6 @@ static int __init unittest_data_add(void) pr_warn("%s: No tree to attach; not running tests\n", __func__); return -ENODATA; } - of_node_set_flag(unittest_data_node, OF_DETACHED); rc = of_resolve_phandles(unittest_data_node); if (rc) { pr_err("%s: Failed to resolve phandles (rc=%i)\n", __func__, rc); @@ -2262,7 +2261,6 @@ static int __init overlay_data_add(int onum) ret = 0; goto out_free_data; } - of_node_set_flag(info->np_overlay, OF_DETACHED); ret = of_resolve_phandles(info->np_overlay); if (ret) { -- 2.14.GIT