From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757560AbdJMJzi (ORCPT ); Fri, 13 Oct 2017 05:55:38 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:47008 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbdJMJzg (ORCPT ); Fri, 13 Oct 2017 05:55:36 -0400 X-Google-Smtp-Source: AOwi7QA2m+auvQzSHNi8GjG7xFKWMUEh7ZjfM5X28rDMBqA+Kj79LFcAMQiL1d8KSgByXFjJZqcbMQ== Date: Fri, 13 Oct 2017 10:55:33 +0100 From: Lee Jones To: Baolin Wang Cc: Baolin Wang , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, LKML , Mark Brown Subject: Re: [PATCH 1/2] dt-bindings: mfd: Add Spreadtrum SC27xx PMIC documentation Message-ID: <20171013095533.fwbphvrdbuvyr5xo@dell> References: <73965e7fb34d6a96529589cdf48e54e95ed666b8.1507723345.git.baolin.wang@spreadtrum.com> <20171013090726.y6mzuf7fdynnp2rj@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Oct 2017, Baolin Wang wrote: > On 13 October 2017 at 17:07, Lee Jones wrote: > > On Wed, 11 Oct 2017, Baolin Wang wrote: > > > >> This patch adds the binding documentation for Spreadtrum SC27xx series > >> PMIC device. > >> > >> Signed-off-by: Baolin Wang > >> --- > >> .../devicetree/bindings/mfd/sprd,sc27xx-pmic.txt | 23 ++++++++++++++++++++ > >> 1 file changed, 23 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt b/Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt > >> new file mode 100644 > >> index 0000000..333c818 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt > >> @@ -0,0 +1,23 @@ > >> +Spreadtrum SC27xx Power Management Integrated Circuit (PMIC) > > > > More info please. > > > > What does the ship do and what other devices are available. > > OK. I will add more information in next version. > > > > >> +Required properties: > >> +- compatible: Should be "sprd,sc2731". > >> +- reg: SPI chip select. > > > > Really? Not an address? > > Yes, it should be device address. > > > > > What is the range? > > > >> +- spi-max-frequency: Typically set to 26000000. > >> +- interrupts: The interrupt line the device is connected to. > >> +- interrupt-controller: Marks the device node as an interrupt controller. > >> +- #interrupt-cells: The number of cells to describe an PMIC IRQ, should be 2. > > > > What if it's not 2? Will it still work? > > Must be 2, if not it can not work well. Will update in next version. > > > > >> +- #address-cells: Child device offset number of cells, should be 1. > > > > Same. > > OK. > > > > >> +- #size-cells: Child device size number of cells, should be 0. > > > > Same. > > OK. > > > > >> + > >> +Example: > >> +pmic: pmic@0 { > > > > What other nodes are you referencing this one from? > > This node should be under our ADI/SPI master device node, as one SPI > device. I will add the SPI master node in next version. Very > appreciated for your comments. Sorry, what I'm getting at is; is the 'pmic:' label really required? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog