From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758633AbdJMO2w (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Oct 2017 10:28:52 -0400
Received: from mail.kernel.org ([198.145.29.99]:41864 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758349AbdJMO2v (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Oct 2017 10:28:51 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD63921872
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Fri, 13 Oct 2017 10:28:48 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@suse.de>, Balbir Singh <balbir@linux.vnet.ibm.com>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] tracing, memcg, vmscan: Hide trace events when not in
 use
Message-ID: <20171013102848.34dec4a7@gandalf.local.home>
In-Reply-To: <20171013063826.6likzbzmfz6fojl2@dhcp22.suse.cz>
References: <20171012184632.2bd247cd@gandalf.local.home>
        <20171013063826.6likzbzmfz6fojl2@dhcp22.suse.cz>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 13 Oct 2017 08:38:26 +0200
Michal Hocko <mhocko@kernel.org> wrote:

> I do not understand the ftrace machinery 

Not many do :-/

> and I have to admit I was under
> impression that nothing really gets defined if the code using them
> doesn't exist but if this is not the case then this patch makes sense to
> me

Sometimes events are created by kernel proper that are used by modules,
or created by modules to be used by other modules (kvm does this with
kvm_intel and kvm_amd). Unfortunately, for these cases they need to
stay. Or later, I plan on moving them to where they are used, because
they have the same issue (wasting memory).

> 
> > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>  
> 
> Acked-by: Michal Hocko <mhocko@suse.com>

Thanks!

-- Steve