From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758219AbdJMOGW (ORCPT ); Fri, 13 Oct 2017 10:06:22 -0400 Received: from omzsmtpe03.verizonbusiness.com ([199.249.25.208]:48853 "EHLO omzsmtpe03.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758130AbdJMOGU (ORCPT ); Fri, 13 Oct 2017 10:06:20 -0400 From: "Levin, Alexander (Sasha Levin)" X-Host: endeavour.tdc.vzwcorp.com To: Michal Hocko CC: "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kmemcheck: correctly remove kmemcheck call from dma_map_sg_attrs Thread-Topic: [PATCH] kmemcheck: correctly remove kmemcheck call from dma_map_sg_attrs Thread-Index: AQHTRCxWLr+f0qMs2kWnjAdflD4ikg== Date: Fri, 13 Oct 2017 14:05:35 +0000 Message-ID: <20171013140532.ro55tfh4yagk5cc6@sasha-lappy> References: <20171012192151.26531-1-alexander.levin@verizon.com> <20171013071121.4v73j7gn472ezv23@dhcp22.suse.cz> In-Reply-To: <20171013071121.4v73j7gn472ezv23@dhcp22.suse.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: NeoMutt/20170113 (1.7.2) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="us-ascii" Content-ID: <51BDF84E79FC1945A99D96160220DB38@vzwcorp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9DE6QsF007371 On Fri, Oct 13, 2017 at 09:11:21AM +0200, Michal Hocko wrote: >On Thu 12-10-17 19:22:05, Sasha Levin wrote: >> We have missed removing some code as part of removing the kmemcheck >> hooks. >> >> Unfourtenatly this got missed during my review, and the code was >> still building. >> >> Reported-by: Michal Hocko >> Signed-off-by: Sasha Levin > >Yes this would be the proper fix for the specific issue I have noticed. >There might be others I haven't even checked. Really the only way to >make this chage is to post a reproducible steps to regenerate your diff >and review that the used scripts are correct. Follow up fixes are not a >way to go So the only part of this series that was scripted to some extend was this commit we're looking at. The 3 other commits are done manually (although their large size is mostly attributed to 'git rm'). Even for this commit, I don't see a way to have it completely scripted given that we're not simply removing calls. I've looked at the ~50 deletions of kmemcheck calls in this commit to make sure they make sense. -- Thanks, Sasha