From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758260AbdJMOWl (ORCPT ); Fri, 13 Oct 2017 10:22:41 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:54714 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753329AbdJMOWi (ORCPT ); Fri, 13 Oct 2017 10:22:38 -0400 From: Arnd Bergmann To: Steven Rostedt , Ingo Molnar Cc: Arnd Bergmann , Joel Fernandes , linux-kernel@vger.kernel.org Subject: [PATCH] [v2] tracing: mark trace_test_buffer as __maybe_unused Date: Fri, 13 Oct 2017 16:22:20 +0200 Message-Id: <20171013142227.1273469-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:zEvWxuCmAOKcULpayT78xRGktm89dWYDiB6ckaauTI6EDbO1C2c TgM0XG9PmmpneKu2dPcfG9/VZNd35M766G+G4WeIylFvIhNm70NMnEASEDKvc30YnI9zdih BD7qe/+ZQo/qrqH+LnOAGh34lWvxDZxcubYut0prdq5jMocdl3kXVDfT9ah9meHhpoyTggI zStyHjWcO5Rjp3PFKoTTA== X-UI-Out-Filterresults: notjunk:1;V01:K0:1AuMBn1gXcg=:i2WygwAxP+YhwhgN3QCM6m jK1+RTPOmAJqZ4IFSxa3HRdBUj3yZwor0tg9/kugfUxsUsmd0zJu0APXEk05wfUj8MVo6EY90 1Ifl1bKz7E/2dNoXioNUr5m5AMOJxBB2I6MnrGFDFAutMQ4PfE1NOIW4qZxMMpK3Sj2v7ZEU1 QFrOW3xVPcekQxaP05vHTfBgSJ/YKxphbW5+cVI8CxG0vbw+JT3Hnog4cL67qIooNdJkpeDFb fq7BqcVqSDenJF+WURBj0Iuvh3OS65RItVjtxG+Z4gJip7jW4NNgt2IFDm+fD9nFUv2zu7FZ/ RwmfkrGEUERZ06hFmgSKCWHTfWVsyASN3picY0J7m9MWTadKMYXkZO2ZwNp7U8kqQPz3c7taJ Nyq7u2WV/F4Q8VF6jni4a1smZViGP3PP7pAu8xGYrZTjTgRdpUHvvE0YY9mxsyPRYNv+EVC7p ozhI/dEtAwzLm/1f89x14RK2b3yavjRjqzDkpSLfPG66O63KrRue+aYgeZef+JmYGhTu7IQOL SYcH0ECi4k6Mfztab3CsIc+pDkdTOMx905AtO2FMkKhsNurA8m3Q9soVg35qxS0pou0OmuLPb nnJKnFfuf7uxePmqe6l87gEGmYmDdARLAW5vnTQxbSJnuOqjaALIHInXvuoCCpGJLpt9ybRko aVPRXGR3W0xJqno4a39TyYWNKYHPRh/vSXshELzsMBZjJpOnDyquBJKj4hPNZD+CiIMzjiETL ix2lipSTSaCbqoC6W0oG2lk6iWz/mfPiB+Gfog== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After trace_selftest_startup_sched_switch is removed, trace_test_buffer() is only used sometimes, leading to this warning: kernel/trace/trace_selftest.c:62:12: error: 'trace_test_buffer' defined but not used [-Werror=unused-function] There is no simple #ifdef condition that captures well whether the function is in fact used or not, so marking it as __maybe_unused is probably the best way to shut up the warning. The function will then be silently dropped when there is no user. Fixes: d8c4deee6dc6 ("tracing: Remove obsolete sched_switch tracer selftest") Signed-off-by: Arnd Bergmann --- v2: use __maybe_unused instead of another incorrect #ifdef --- kernel/trace/trace_selftest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c index 364f78abdf47..eb9ba5c1ba40 100644 --- a/kernel/trace/trace_selftest.c +++ b/kernel/trace/trace_selftest.c @@ -59,7 +59,7 @@ static int trace_test_buffer_cpu(struct trace_buffer *buf, int cpu) * Test the trace buffer to see if all the elements * are still sane. */ -static int trace_test_buffer(struct trace_buffer *buf, unsigned long *count) +static int __maybe_unused trace_test_buffer(struct trace_buffer *buf, unsigned long *count) { unsigned long flags, cnt = 0; int cpu, ret = 0; -- 2.9.0