From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbdJNXSD (ORCPT ); Sat, 14 Oct 2017 19:18:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51030 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbdJNXSC (ORCPT ); Sat, 14 Oct 2017 19:18:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A4F8A356C2 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=ming.lei@redhat.com Date: Sun, 15 Oct 2017 07:17:46 +0800 From: Ming Lei To: Jens Axboe Cc: linux-block@vger.kernel.org, Christoph Hellwig , Bart Van Assche , Laurence Oberman , Paolo Valente , Oleksandr Natalenko , Tom Nguyen , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Omar Sandoval , John Garry Subject: Re: [PATCH V10 0/8] blk-mq-sched: improve sequential I/O performance Message-ID: <20171014231744.GB17485@ming.t460p> References: <20171014092232.13943-1-ming.lei@redhat.com> <1c643ef1-26d8-3fa4-2b65-7e299e6a5ceb@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c643ef1-26d8-3fa4-2b65-7e299e6a5ceb@kernel.dk> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Sat, 14 Oct 2017 23:18:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 14, 2017 at 09:39:21AM -0600, Jens Axboe wrote: > On 10/14/2017 03:22 AM, Ming Lei wrote: > > Hi Jens, > > > > In Red Hat internal storage test wrt. blk-mq scheduler, we found that I/O > > performance is much bad with mq-deadline, especially about sequential I/O > > on some multi-queue SCSI devcies(lpfc, qla2xxx, SRP...) > > > > Turns out one big issue causes the performance regression: requests are > > still dequeued from sw queue/scheduler queue even when ldd's queue is > > busy, so I/O merge becomes quite difficult to make, then sequential IO > > performance degrades a lot. > > > > This issue becomes one of mains reasons for reverting default SCSI_MQ > > in V4.13. > > > > This 8 patches improve this situation, and brings back performance loss. > > > > With this change, SCSI-MQ sequential I/O performance is improved much, Paolo > > reported that mq-deadline performance improved much[2] in his dbench test > > wrt V2. Also performance improvement on lpfc/qla2xx was observed with V1.[1] > > Looks good to me, and the kyber fix looks obviously correct to me. I have > applied this series for 4.15. Thanks Ming. That is great, thanks for making this patchset in! -- Ming