From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbdJOUqb (ORCPT ); Sun, 15 Oct 2017 16:46:31 -0400 Received: from mail.skyhub.de ([5.9.137.197]:50932 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbdJOUqa (ORCPT ); Sun, 15 Oct 2017 16:46:30 -0400 Date: Sun, 15 Oct 2017 22:46:06 +0200 From: Borislav Petkov To: Colin King Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/intel_cacheinfo: remove redundant assignment to this_leaf Message-ID: <20171015204606.gs67hxz32g4skjca@pd.tnic> References: <20171015160203.12332-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171015160203.12332-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 15, 2017 at 05:02:03PM +0100, Colin King wrote: > From: Colin Ian King > > The variable this_leaf is being assigned a value that is never > read and it is being updated a little later with a newer value, > hence we can remove the redundant assignment. > > Cleans up clang warning: Value stored to 'this_leaf' is never read > > Signed-off-by: Colin Ian King > --- > arch/x86/kernel/cpu/intel_cacheinfo.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c > index 24f749324c0f..9990a71e311f 100644 > --- a/arch/x86/kernel/cpu/intel_cacheinfo.c > +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c > @@ -831,7 +831,6 @@ static int __cache_amd_cpumap_setup(unsigned int cpu, int index, > } else if (boot_cpu_has(X86_FEATURE_TOPOEXT)) { > unsigned int apicid, nshared, first, last; > > - this_leaf = this_cpu_ci->info_list + index; > nshared = base->eax.split.num_threads_sharing + 1; > apicid = cpu_data(cpu).apicid; > first = apicid - (apicid % nshared); > -- Looks ok to me. Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.