From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932360AbdJPTyi (ORCPT ); Mon, 16 Oct 2017 15:54:38 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34292 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932337AbdJPTyh (ORCPT ); Mon, 16 Oct 2017 15:54:37 -0400 Date: Mon, 16 Oct 2017 20:54:34 +0100 (WEST) Message-Id: <20171016.205434.1066116631088582472.davem@davemloft.net> To: rostedt@goodmis.org Cc: linux-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org Subject: Re: [PATCH] tracing: bpf: Hide bpf trace events when they are not used From: David Miller In-Reply-To: <20171012184002.0661a867@gandalf.local.home> References: <20171012184002.0661a867@gandalf.local.home> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Oct 2017 12:54:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steven Rostedt Date: Thu, 12 Oct 2017 18:40:02 -0400 > From: Steven Rostedt (VMware) > > All the trace events defined in include/trace/events/bpf.h are only > used when CONFIG_BPF_SYSCALL is defined. But this file gets included by > include/linux/bpf_trace.h which is included by the networking code with > CREATE_TRACE_POINTS defined. > > If a trace event is created but not used it still has data structures > and functions created for its use, even though nothing is using them. > To not waste space, do not define the BPF trace events in bpf.h unless > CONFIG_BPF_SYSCALL is defined. > > Signed-off-by: Steven Rostedt (VMware) Steven, I lost track of how this patch is being handled. Do you want me to merge it via my net-next tree?