From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757308AbdJPUVa (ORCPT ); Mon, 16 Oct 2017 16:21:30 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34680 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776AbdJPUV2 (ORCPT ); Mon, 16 Oct 2017 16:21:28 -0400 Date: Mon, 16 Oct 2017 21:21:26 +0100 (WEST) Message-Id: <20171016.212126.2225476616318738346.davem@davemloft.net> To: arnd@arndb.de Cc: f.fainelli@gmail.com, michael.chan@broadcom.com, sathya.perla@broadcom.com, nicolas.pitre@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next] net: systemport: add NET_DSA dependency From: David Miller In-Reply-To: <20171016113258.3735473-1-arnd@arndb.de> References: <20171016113258.3735473-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Oct 2017 13:21:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 16 Oct 2017 13:32:36 +0200 > The notifier cause a link error when NET_DSA is a loadable > module: > > drivers/net/ethernet/broadcom/bcmsysport.o: In function `bcm_sysport_remove': > bcmsysport.c:(.text+0x1582): undefined reference to `unregister_dsa_notifier' > drivers/net/ethernet/broadcom/bcmsysport.o: In function `bcm_sysport_probe': > bcmsysport.c:(.text+0x278d): undefined reference to `register_dsa_notifier' > > This adds a dependency that forces the systemport driver to be > a loadable module as well when that happens, but otherwise > allows it to be built normally when DSA is either built-in or > completely disabled. > > Fixes: d156576362c0 ("net: systemport: Establish lower/upper queue mapping") > Signed-off-by: Arnd Bergmann Applied, thank you.